Repository navigation
Use selected dashboard year for attendance/grade report groups - #150
Merged
Merged
Conversation
report_group.year was hardcoded to today's computed Hebrew year, ignoring the year selected via the dashboard year switcher. Use defaultYearFilter.year instead, matching lesson lookup in LessonSelector.jsx which already respects it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUhaoVyaHXvVCE6tGRF5MM
There was a problem hiding this comment.
🟢 Approval recommended
Change small, aligns report_group.year with existing year filter mechanism used across client.
Pull request overview
Fix report-group year stamping in in-lesson attendance/grade report flow so saved report_group.year matches dashboard YearSelector selection (localStorage-backed), not today computed Hebrew year.
Changes:
- Swap
getCurrentHebrewYear()usage fordefaultYearFilter.yearwhen creatingreport_group - Update import to use
defaultYearFilterfrom@shared/utils/yearFilter
File summaries
| File | Description |
|---|---|
| client/src/reports/InLessonReport.jsx | Set report_group.year from selected dashboard year (defaultYearFilter.year) |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_group.year, set when saving attendance/grade entries from the lesson report form, was hardcoded to today's computed Hebrew year (getCurrentHebrewYear()) — ignoring the year selected via the dashboard year switcher. Now usesdefaultYearFilter.year, matching the lesson lookup inLessonSelector.jsx, which already respects the selected year.Change
client/src/reports/InLessonReport.jsx:year: getCurrentHebrewYear()→year: defaultYearFilter.year🤖 Generated with Claude Code
Generated by Claude Code