Skip to content

Use selected dashboard year for attendance/grade report groups - #150

Merged
buzz-code merged 1 commit into
mainfrom
claude/attendance-year-selection-dbzv98
Aug 23, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/attendance-year-selection-dbzv98

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

report_group.year, set when saving attendance/grade entries from the lesson report form, was hardcoded to today's computed Hebrew year (getCurrentHebrewYear()) — ignoring the year selected via the dashboard year switcher. Now uses defaultYearFilter.year, matching the lesson lookup in LessonSelector.jsx, which already respects the selected year.

Change

  • client/src/reports/InLessonReport.jsx: year: getCurrentHebrewYear() → year: defaultYearFilter.year

🤖 Generated with Claude Code


Generated by Claude Code

report_group.year was hardcoded to today's computed Hebrew year,
ignoring the year selected via the dashboard year switcher. Use
defaultYearFilter.year instead, matching lesson lookup in
LessonSelector.jsx which already respects it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUhaoVyaHXvVCE6tGRF5MM
Copilot AI lite review requested due to automatic review settings August 23, 2026 19:01
@buzz-code
buzz-code merged commit e5b8fef into main Aug 23, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Change small, aligns report_group.year with existing year filter mechanism used across client.

Pull request overview

Fix report-group year stamping in in-lesson attendance/grade report flow so saved report_group.year matches dashboard YearSelector selection (localStorage-backed), not today computed Hebrew year.

Changes:

  • Swap getCurrentHebrewYear() usage for defaultYearFilter.year when creating report_group
  • Update import to use defaultYearFilter from @shared/utils/yearFilter
File summaries
File Description
client/src/reports/InLessonReport.jsx Set report_group.year from selected dashboard year (defaultYearFilter.year)
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants