Skip to content

Send selected year on attendance/grade entries in lesson report form - #154

Merged
buzz-code merged 1 commit into
mainfrom
claude/attendance-year-selection-dbzv98
Aug 23, 2026
Merged

buzz-code merged 1 commit into
mainfrom
claude/attendance-year-selection-dbzv98

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

Follow-up to #150. report_group.year was fixed to use defaultYearFilter.year, but the individual att_report/grade rows built in handleSave still omitted year, falling back to the server's fillDefaultYearValue (today's computed Hebrew year) instead of the AppBar-selected year.

Change

  • client/src/reports/in-lesson-report/index.jsx: entry object now sets year: defaultYearFilter.year
  • report_group_session has no year column — nothing to change there

🤖 Generated with Claude Code


Generated by Claude Code

report_group.year was already fixed to use defaultYearFilter.year; the
individual att_report/grade rows built in handleSave still omitted year,
falling back to server's fillDefaultYearValue (today's computed year).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUhaoVyaHXvVCE6tGRF5MM
Copilot AI lite review requested due to automatic review settings August 23, 2026 19:22
@buzz-code
buzz-code merged commit 60e1f29 into main Aug 23, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Change small, localized, matches stated goal of sending selected year into saved attendance/grade rows.

Pull request overview

Send dashboard-selected year into in-lesson report save payload, so created att_report / grade rows stop falling back to server default year.

Changes:

  • Replace getCurrentHebrewYear() usage with defaultYearFilter.year for saved row entries
  • Add year field into entry object built in handleSave
File summaries
File Description
client/src/reports/in-lesson-report/index.jsx Add year: defaultYearFilter.year to saved entry payload, align with dashboard year selector
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants