Repository navigation
Send selected year on attendance/grade entries in lesson report form - #154
Merged
Merged
Conversation
report_group.year was already fixed to use defaultYearFilter.year; the individual att_report/grade rows built in handleSave still omitted year, falling back to server's fillDefaultYearValue (today's computed year). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UUhaoVyaHXvVCE6tGRF5MM
There was a problem hiding this comment.
🟢 Approval recommended
Change small, localized, matches stated goal of sending selected year into saved attendance/grade rows.
Pull request overview
Send dashboard-selected year into in-lesson report save payload, so created att_report / grade rows stop falling back to server default year.
Changes:
- Replace
getCurrentHebrewYear()usage withdefaultYearFilter.yearfor saved row entries - Add
yearfield intoentryobject built inhandleSave
File summaries
| File | Description |
|---|---|
| client/src/reports/in-lesson-report/index.jsx | Add year: defaultYearFilter.year to saved entry payload, align with dashboard year selector |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #150.
report_group.yearwas fixed to usedefaultYearFilter.year, but the individualatt_report/graderows built inhandleSavestill omittedyear, falling back to the server'sfillDefaultYearValue(today's computed Hebrew year) instead of the AppBar-selected year.Change
client/src/reports/in-lesson-report/index.jsx:entryobject now setsyear: defaultYearFilter.yearreport_group_sessionhas noyearcolumn — nothing to change there🤖 Generated with Claude Code
Generated by Claude Code