Repository navigation
Add public homepage at "/" for SEO, login moves to "/login" - #107
Merged
Merged
Conversation
Bumps client/shared to pick up AdminAppShell's new homeContent prop: anonymous visitors hitting "/" now see a marketing/explainer page (what "נוכחות" does, for schools evaluating it) instead of the login form; login moves to "/login". Also updates index.html meta/OG tags and title with real descriptive copy instead of the CRA placeholder.
Picks up two fixes discovered by testing this against a mock backend: - The homepage is now registered as a real CustomRoutes route (only while anonymous), not via loginPage - the previous approach never actually rendered since react-admin always mounts loginPage at the fixed "/login" route, not at whatever URL triggered it. - getPermissions() and react-query's retry backoff no longer leave anonymous visitors on a blank spinner for ~7s before the homepage appears. Verified end-to-end (mock backend + headless browser): "/" shows the homepage anonymously, "/login" still shows the unchanged login form, and logging in lands on the real dashboard at "/" exactly as before.
There was a problem hiding this comment.
Pull request overview
This PR adds a public, SEO-friendly homepage at / (for anonymous visitors) while keeping login available at /login, aligning the app’s entry experience with a marketing/explainer landing page for schools evaluating the system.
Changes:
- Add a completed roadmap entry for the new public homepage.
- Provide Hebrew homepage marketing content (tagline + description + feature cards + CTA) to
AdminAppShellvia the newhomeContentprop. - Replace CRA placeholder
<title>/ meta description and add Open Graph tags inclient/index.htmlfor better SEO/social previews.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| client/src/roadmapFeatures.js | Adds a “public homepage” item to the roadmap list. |
| client/src/App.jsx | Supplies homeContent marketing copy to AdminAppShell. |
| client/index.html | Updates SEO metadata (title/description) and adds OG tags. |
Files not reviewed (1)
- client/src/roadmapFeatures.js: Generated file
|
|
||
| const App = () => ( | ||
| <AdminAppShell | ||
| title="נוכחות" |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/sharedto pick upAdminAppShell's newhomeContentprop (nra-client#24): anonymous visitors hitting/now see a marketing/explainer page for "נוכחות" (what the attendance system does, for schools evaluating it) instead of being redirected to the login form. Login is unaffected at/login.AdminAppShellviaApp.jsx.client/index.html's<title>/<meta description>/OG tags with real descriptive copy, replacing the CRA placeholder.roadmapFeatures.jsconvention.Test plan
yarn test(client) — 22 suites / 152 tests passing/shows the homepage anonymously (renders fast, no spinner delay),/loginstill shows the unchanged login form, and logging in lands on the real dashboard at/exactly as beforeGenerated by Claude Code