Skip to content

Add public homepage at "/" for SEO, login moves to "/login" - #107

Merged
buzz-code merged 2 commits into
mainfrom
claude/project-homepage-seo-kl9987
Jul 13, 2026
Merged

buzz-code merged 2 commits into
mainfrom
claude/project-homepage-seo-kl9987

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

  • Bumps client/shared to pick up AdminAppShell's new homeContent prop (nra-client#24): anonymous visitors hitting / now see a marketing/explainer page for "נוכחות" (what the attendance system does, for schools evaluating it) instead of being redirected to the login form. Login is unaffected at /login.
  • Passes Hebrew marketing copy (tagline + 3 feature cards) into AdminAppShell via App.jsx.
  • Updates client/index.html's <title>/<meta description>/OG tags with real descriptive copy, replacing the CRA placeholder.
  • Adds a roadmap entry per this project's roadmapFeatures.js convention.

Test plan

  • yarn test (client) — 22 suites / 152 tests passing
  • End-to-end manual verification against a mock backend + headless browser: / shows the homepage anonymously (renders fast, no spinner delay), /login still shows the unchanged login form, and logging in lands on the real dashboard at / exactly as before
  • No route or behavior changes for authenticated users (dashboard, resource routes, existing bookmarks all unaffected)

Generated by Claude Code

claude added 2 commits July 13, 2026 08:36
Bumps client/shared to pick up AdminAppShell's new homeContent prop:
anonymous visitors hitting "/" now see a marketing/explainer page
(what "נוכחות" does, for schools evaluating it) instead of the login
form; login moves to "/login". Also updates index.html meta/OG tags
and title with real descriptive copy instead of the CRA placeholder.
Picks up two fixes discovered by testing this against a mock backend:
- The homepage is now registered as a real CustomRoutes route (only
  while anonymous), not via loginPage - the previous approach never
  actually rendered since react-admin always mounts loginPage at the
  fixed "/login" route, not at whatever URL triggered it.
- getPermissions() and react-query's retry backoff no longer leave
  anonymous visitors on a blank spinner for ~7s before the homepage
  appears.

Verified end-to-end (mock backend + headless browser): "/" shows the
homepage anonymously, "/login" still shows the unchanged login form,
and logging in lands on the real dashboard at "/" exactly as before.
Copilot AI review requested due to automatic review settings July 13, 2026 09:24
@buzz-code
buzz-code merged commit aecae18 into main Jul 13, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public, SEO-friendly homepage at / (for anonymous visitors) while keeping login available at /login, aligning the app’s entry experience with a marketing/explainer landing page for schools evaluating the system.

Changes:

  • Add a completed roadmap entry for the new public homepage.
  • Provide Hebrew homepage marketing content (tagline + description + feature cards + CTA) to AdminAppShell via the new homeContent prop.
  • Replace CRA placeholder <title> / meta description and add Open Graph tags in client/index.html for better SEO/social previews.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
client/src/roadmapFeatures.js Adds a “public homepage” item to the roadmap list.
client/src/App.jsx Supplies homeContent marketing copy to AdminAppShell.
client/index.html Updates SEO metadata (title/description) and adds OG tags.
Files not reviewed (1)
  • client/src/roadmapFeatures.js: Generated file

Comment thread client/src/App.jsx

const App = () => (
<AdminAppShell
title="נוכחות"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants