Repository navigation
Homepage: richer content, verified copy, moved out of App.jsx - #109
Merged
Merged
Conversation
- Moves the homeContent object out of App.jsx into src/homeContent.js, so App.jsx (already large) doesn't also carry marketing copy. - Rewrites the feature set after actually checking each claim against the codebase instead of assuming: Excel/email import were described as narrow (lesson-schedule + one payroll template; one dedicated mailbox) when both are generic, per-entity infrastructure used by 15+ entities (client/src/entities: grep -l importer) and every entity module (server's POST /:entity/handle-email in base-entity.module.ts). - Trims the page back to a single feature grid (drops the "how it works"/closing-CTA sections from the shared component - still available there for other apps, just not used here) per feedback that the page had gotten too long. - Bumps client/shared to pick up nra-client's homepage fixes, including the AdminAppShell/HomePage/authProvider review fixes from PR buzz-code/nra-client#25 (children-as-node support, stale doc comment, no user-facing message on the getPermissions() fast-path rejection).
There was a problem hiding this comment.
Pull request overview
This PR refactors and enriches the public homepage (“/”) marketing content by extracting homeContent out of client/src/App.jsx into a dedicated module, and expanding the content to a richer, icon-based 6-feature layout intended for anonymous visitors.
Changes:
- Added
client/src/homeContent.jsto centralize and expand homepage copy + feature definitions (including per-feature icons and an eyebrow label). - Updated
client/src/App.jsxto importhomeContentfrom the new module and pass it intoAdminAppShell.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/homeContent.js | New, standalone homepage content module with updated copy and feature card definitions (incl. icons/eyebrow). |
| client/src/App.jsx | Removes inline homeContent object and wires AdminAppShell to the extracted module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #107/#108. Reworks the homepage content based on feedback:
homeContentout ofApp.jsx(already large) into its ownclient/src/homeContent.js.grep -rl importer client/src/entities) and exposed on every entity module server-side (POST /:entity/handle-emailinbase-entity.module.ts).HomePage(shared component): icons on feature cards, an eyebrow badge, and a grid that avoids ever leaving a single card orphaned on its own row for any feature count.client/sharedtonra-clientmain, which includes theAdminAppShell/authProviderreview fixes from nra-client#24/Clean shared folder #25 (children-as-node support, no user-facing message on the internal fast-path rejection) and the HomePage grid fix from Copilot's review.Test plan
yarn test(client) - 23 suites / 157 tests passingGenerated by Claude Code