Skip to content

Homepage: richer content, verified copy, moved out of App.jsx - #109

Merged
buzz-code merged 3 commits into
mainfrom
claude/homepage-richer-content
Jul 13, 2026
Merged

buzz-code merged 3 commits into
mainfrom
claude/homepage-richer-content

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Summary

Follow-up to #107/#108. Reworks the homepage content based on feedback:

  • Moves homeContent out of App.jsx (already large) into its own client/src/homeContent.js.
  • Replaces the feature list with 6 features, each verified against actual code before writing the copy (not assumed) - notably corrects two claims that turned out to be too narrow:
    • Excel/email import isn't limited to a couple of specific files - it's generic, per-entity infrastructure used by 15+ entities client-side (grep -rl importer client/src/entities) and exposed on every entity module server-side (POST /:entity/handle-email in base-entity.module.ts).
  • Redesigned HomePage (shared component): icons on feature cards, an eyebrow badge, and a grid that avoids ever leaving a single card orphaned on its own row for any feature count.
  • Bumps client/shared to nra-client main, which includes the AdminAppShell/authProvider review fixes from nra-client#24/Clean shared folder #25 (children-as-node support, no user-facing message on the internal fast-path rejection) and the HomePage grid fix from Copilot's review.

Test plan

  • yarn test (client) - 23 suites / 157 tests passing
  • Manual visual verification against a mock backend + headless browser
  • No route or behavior changes for authenticated users

Generated by Claude Code

claude added 3 commits July 13, 2026 10:04
- Moves the homeContent object out of App.jsx into src/homeContent.js,
  so App.jsx (already large) doesn't also carry marketing copy.
- Rewrites the feature set after actually checking each claim against
  the codebase instead of assuming: Excel/email import were described
  as narrow (lesson-schedule + one payroll template; one dedicated
  mailbox) when both are generic, per-entity infrastructure used by 15+
  entities (client/src/entities: grep -l importer) and every entity
  module (server's POST /:entity/handle-email in base-entity.module.ts).
- Trims the page back to a single feature grid (drops the "how it
  works"/closing-CTA sections from the shared component - still
  available there for other apps, just not used here) per feedback
  that the page had gotten too long.
- Bumps client/shared to pick up nra-client's homepage fixes, including
  the AdminAppShell/HomePage/authProvider review fixes from PR buzz-code/nra-client#25
  (children-as-node support, stale doc comment, no user-facing message
  on the getPermissions() fast-path rejection).
Copilot AI review requested due to automatic review settings July 13, 2026 13:21
@buzz-code
buzz-code merged commit cc78255 into main Jul 13, 2026
1 check failed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors and enriches the public homepage (“/”) marketing content by extracting homeContent out of client/src/App.jsx into a dedicated module, and expanding the content to a richer, icon-based 6-feature layout intended for anonymous visitors.

Changes:

  • Added client/src/homeContent.js to centralize and expand homepage copy + feature definitions (including per-feature icons and an eyebrow label).
  • Updated client/src/App.jsx to import homeContent from the new module and pass it into AdminAppShell.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
client/src/homeContent.js New, standalone homepage content module with updated copy and feature card definitions (incl. icons/eyebrow).
client/src/App.jsx Removes inline homeContent object and wires AdminAppShell to the extracted module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants