Repository navigation
Fix vendor chunk runtime crash from previous manualChunks split - #100
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manualChunkssplit (merged in Bump client/shared submodule to fix vite chunk size warning #99) separatedreact,@mui/material,react-admin/ra-core, andra-ui-materialuiinto individual chunks. Those packages are tightly interdependent, and splitting them broke module init order, causing a runtime crash on load:Cannot read properties of undefined (reading '__esModule').client/sharedto thenra-clientfix: react/MUI/react-admin/ra-core/ra-ui-materialui are kept together in one chunk again. Onlyxlsxand the@openobservetelemetry SDKs (which have no dependency on the framework stack) remain split out.chunkSizeWarningLimitraised to 2700 to reflect the consolidated framework chunk's real size (~2.5 MiB) instead of chasing an arbitrary split that isn't safe.Test plan
yarn buildcompletes cleanly, no chunk-size warningvite previewand loaded it in a headless browser — nopageerror, no__esModuleexception; page renders correctly (confirmed via screenshot)Generated by Claude Code