Repository navigation
Split rich-text and misc leaf libs into own chunks - #101
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the client/shared submodule (nra-client) to refine the Vite/Rollup manualChunks strategy so certain “leaf” vendor libraries (rich-text + small utilities) are emitted as their own chunks, improving cache granularity without reintroducing the circular-chunk runtime crash addressed in #100.
Changes:
- Bump
client/sharedsubmodule tonra-client@90bcd6b(from8620e66). - In the bumped
nra-client, expandmanualChunksto add dedicated chunks forra-input-rich-textand a small set of standalone utilities (while keeping the react/MUI/react-admin stack grouped together).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/shared(nra-client) to further split the vendor bundle:ra-input-rich-textand a handful of small standalone utilities (ra-data-nestjsx-crud,@nestjsx/crud-request,jewish-date,react-admin-json-view,stylis,stylis-plugin-rtl,file-saver) now get their own chunks.react/@mui/react-admin/ra-core/ra-ui-materialuiframework bundle (depended on, never the other way around), so splitting them out can't reintroduce the circular-chunk crash fixed in Fix vendor chunk runtime crash from previous manualChunks split #100 — verified in a headless browser with nopageerror.Test plan
yarn buildcompletes cleanly, no chunk-size warningvite previewand loaded it in a headless browser — nopageerror, page renders correctlyGenerated by Claude Code