Repository navigation
Point the installer and docs at btraceio/agent-plugins, where jafar-perf now lives - #120
Merged
Merged
Conversation
…erf now lives The jafar-perf plugin moved from btraceio/jafar-perf-box into the btraceio/agent-plugins marketplace (btraceio/agent-plugins#8). install.sh and the docs still named the old repository and the old marketplace, so the installer would have set people up with a frozen copy that never gets `--attach` or any later change. - install.sh adds btraceio/agent-plugins and installs jafar-perf@btraceio-agent-plugins for Claude Code, and installs git:github.com/btraceio/agent-plugins for pi. - Re-running the installer migrates an existing install: once the new copy is in place it uninstalls jafar-perf@btraceio and removes the old marketplace (Claude Code) and removes the old package (pi), so the skills and agents are not loaded twice. It does this only after the new install succeeds, and a failure to remove the old one warns instead of failing the install. - README.md, jfr-mcp/README.md, doc/agents/Mcp.md, doc/mcp/WhenToUseWhich.md and doc/cli/AskTutorial.md name the new repository and marketplace. doc/agents/Mcp.md now says where the tool-drift check runs. CHANGELOG.md and doc/plans keep their history. For pi the new package is the whole agent-plugins package, so it also brings the other btraceio skills, and it only brings the jafar MCP server once btraceio/agent-plugins registers it (the pi.mcp entry in its package.json): this should merge after that change. Verified: in a scratch HOME set up the old way (marketplace btraceio, jafar-perf@btraceio, the jafar-perf-box pi package), `install.sh --harness claude,pi` ended with only jafar-perf@btraceio-agent-plugins and the btraceio-agent-plugins marketplace for Claude Code, and only git:github.com/btraceio/agent-plugins plus pi-mcp-adapter for pi; a second run changed nothing and printed no warnings. shellcheck is clean and `bash -n` passes. Not run: --daemon, --dev, and a live pi session. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jbachorik
marked this pull request as ready for review
October 3, 2026 19:49
Contributor
Combined JUnit Test Report
HTML Test ReportsRun artifacts: https://github.com/btraceio/jafar/actions/runs/37149124323
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The
jafar-perfplugin moved frombtraceio/jafar-perf-boxinto thebtraceio/agent-pluginsmarketplace (btraceio/agent-plugins#8).install.shand the docs still named the old repository and the old marketplace, so the installer would set people up with a frozen copy that never gets--attachor any later change.install.shaddsbtraceio/agent-pluginsand installsjafar-perf@btraceio-agent-pluginsfor Claude Code, and installsgit:github.com/btraceio/agent-pluginsfor pi.jafar-perf@btraceioand removes the old marketplace (Claude Code), and removes the old package (pi). It does this only after the new install succeeds, so a failed install never leaves a machine without the plugin, and a failure to remove the old copy warns instead of failing.README.md,jfr-mcp/README.md,doc/agents/Mcp.md,doc/mcp/WhenToUseWhich.mdanddoc/cli/AskTutorial.mdname the new repository and marketplace.doc/agents/Mcp.mdalso says where the tool-drift check now runs and what it does and does not catch (a renamed or removed tool, not a changed parameter).CHANGELOG.mdanddoc/planskeep their history.Merge after btraceio/agent-plugins#10. For pi the new package only brings the jafar MCP server once that package registers it (
pi.mcp); until then a pi user would get skills and no server. For pi the package is also the whole agent-plugins package, so it brings the other btraceio skills too (the installer says so).How verified
HOMEset up the old way (marketplacebtraceio,jafar-perf@btraceio, thejafar-perf-boxpi package), theninstall.sh --harness claude,pijafar-perf@btraceio-agent-pluginsand thebtraceio-agent-pluginsmarketplace; pi ends with onlygit:github.com/btraceio/agent-pluginspluspi-mcp-adapter; the log reports each removalinstall.sh --harness claude,pirunshellcheck -S warning install.sh,bash -n install.shgit grep jafar-perf-boxoutsideCHANGELOG.mdanddoc/plansCoverage notes
There are no automated tests for
install.sh; the migration was exercised for real against the Claude Code and pi CLIs with the actual old and new repositories, in a scratchHOME.Not verified / known limitations
--daemon,--dev, and a live pi session using the server.jfr-mcp/install.sh(whichinstall.shwraps) still printsjbang jfr-mcp@btraceio --stdioin its client hints rather than--stdio --attach. Both work; I left it out of this change.$HOME, so the scratch runs re-installed~/.jbang/bin/jfr-mcpon my machine (same content). Nothing else outside the scratch directory was touched.Why this is a draft: it should merge after btraceio/agent-plugins#10, and the items above are open. It flips to ready once that merges.
Breaking changes / migration
Anyone who installed through the old route is migrated by re-running the installer; by hand it is
/plugin marketplace remove btraceio,/plugin marketplace add btraceio/agent-plugins,/plugin install jafar-perf@btraceio-agent-plugins(the README has the commands). No change for anyone who has not installed the plugin.Links
Depends on btraceio/agent-plugins#10 (pi MCP registration). Follows #119 and btraceio/agent-plugins#8. Once both merge,
btraceio/jafar-perf-boxcan be archived; its README pointer is prepared.🤖 Generated with Claude Code