Skip to content

Point the installer and docs at btraceio/agent-plugins, where jafar-perf now lives - #120

Merged
jbachorik merged 1 commit into
mainfrom
fix/repoint-jafar-perf-to-agent-plugins
Oct 3, 2026
Merged

jbachorik merged 1 commit into
mainfrom
fix/repoint-jafar-perf-to-agent-plugins

Conversation

@jbachorik

Copy link
Copy Markdown
Collaborator

What & why

The jafar-perf plugin moved from btraceio/jafar-perf-box into the btraceio/agent-plugins marketplace (btraceio/agent-plugins#8). install.sh and the docs still named the old repository and the old marketplace, so the installer would set people up with a frozen copy that never gets --attach or any later change.

  • install.sh adds btraceio/agent-plugins and installs jafar-perf@btraceio-agent-plugins for Claude Code, and installs git:github.com/btraceio/agent-plugins for pi.
  • Re-running it migrates an existing install. Without that, anyone who ran the old installer would end up with the plugin twice (duplicate skills and agents). Once the new copy is in place it uninstalls jafar-perf@btraceio and removes the old marketplace (Claude Code), and removes the old package (pi). It does this only after the new install succeeds, so a failed install never leaves a machine without the plugin, and a failure to remove the old copy warns instead of failing.
  • Docs: README.md, jfr-mcp/README.md, doc/agents/Mcp.md, doc/mcp/WhenToUseWhich.md and doc/cli/AskTutorial.md name the new repository and marketplace. doc/agents/Mcp.md also says where the tool-drift check now runs and what it does and does not catch (a renamed or removed tool, not a changed parameter). CHANGELOG.md and doc/plans keep their history.

Merge after btraceio/agent-plugins#10. For pi the new package only brings the jafar MCP server once that package registers it (pi.mcp); until then a pi user would get skills and no server. For pi the package is also the whole agent-plugins package, so it brings the other btraceio skills too (the installer says so).

How verified

Command Result
scratch HOME set up the old way (marketplace btraceio, jafar-perf@btraceio, the jafar-perf-box pi package), then install.sh --harness claude,pi Claude Code ends with only jafar-perf@btraceio-agent-plugins and the btraceio-agent-plugins marketplace; pi ends with only git:github.com/btraceio/agent-plugins plus pi-mcp-adapter; the log reports each removal
a second install.sh --harness claude,pi run changes nothing, no warnings, exit 0
shellcheck -S warning install.sh, bash -n install.sh clean
git grep jafar-perf-box outside CHANGELOG.md and doc/plans only the intentional migration references

Coverage notes

There are no automated tests for install.sh; the migration was exercised for real against the Claude Code and pi CLIs with the actual old and new repositories, in a scratch HOME.

Not verified / known limitations

  • --daemon, --dev, and a live pi session using the server.
  • jfr-mcp/install.sh (which install.sh wraps) still prints jbang jfr-mcp@btraceio --stdio in its client hints rather than --stdio --attach. Both work; I left it out of this change.
  • Side effect of my own testing, for the record: jbang resolves its directory from the user's real home rather than $HOME, so the scratch runs re-installed ~/.jbang/bin/jfr-mcp on my machine (same content). Nothing else outside the scratch directory was touched.

Why this is a draft: it should merge after btraceio/agent-plugins#10, and the items above are open. It flips to ready once that merges.

Breaking changes / migration

Anyone who installed through the old route is migrated by re-running the installer; by hand it is /plugin marketplace remove btraceio, /plugin marketplace add btraceio/agent-plugins, /plugin install jafar-perf@btraceio-agent-plugins (the README has the commands). No change for anyone who has not installed the plugin.

Links

Depends on btraceio/agent-plugins#10 (pi MCP registration). Follows #119 and btraceio/agent-plugins#8. Once both merge, btraceio/jafar-perf-box can be archived; its README pointer is prepared.

🤖 Generated with Claude Code

…erf now lives

The jafar-perf plugin moved from btraceio/jafar-perf-box into the btraceio/agent-plugins
marketplace (btraceio/agent-plugins#8). install.sh and the docs still named the old
repository and the old marketplace, so the installer would have set people up with a
frozen copy that never gets `--attach` or any later change.

- install.sh adds btraceio/agent-plugins and installs jafar-perf@btraceio-agent-plugins
  for Claude Code, and installs git:github.com/btraceio/agent-plugins for pi.
- Re-running the installer migrates an existing install: once the new copy is in place it
  uninstalls jafar-perf@btraceio and removes the old marketplace (Claude Code) and removes
  the old package (pi), so the skills and agents are not loaded twice. It does this only
  after the new install succeeds, and a failure to remove the old one warns instead of
  failing the install.
- README.md, jfr-mcp/README.md, doc/agents/Mcp.md, doc/mcp/WhenToUseWhich.md and
  doc/cli/AskTutorial.md name the new repository and marketplace. doc/agents/Mcp.md now
  says where the tool-drift check runs. CHANGELOG.md and doc/plans keep their history.

For pi the new package is the whole agent-plugins package, so it also brings the other
btraceio skills, and it only brings the jafar MCP server once btraceio/agent-plugins
registers it (the pi.mcp entry in its package.json): this should merge after that change.

Verified: in a scratch HOME set up the old way (marketplace btraceio, jafar-perf@btraceio,
the jafar-perf-box pi package), `install.sh --harness claude,pi` ended with only
jafar-perf@btraceio-agent-plugins and the btraceio-agent-plugins marketplace for Claude
Code, and only git:github.com/btraceio/agent-plugins plus pi-mcp-adapter for pi; a second
run changed nothing and printed no warnings. shellcheck is clean and `bash -n` passes.
Not run: --daemon, --dev, and a live pi session.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Combined JUnit Test Report

  • Total: 2294
  • Passed: 2278
  • Failures: 0
  • Errors: 0
  • Skipped: 16

HTML Test Reports

Run artifacts: https://github.com/btraceio/jafar/actions/runs/37149124323

@jbachorik
jbachorik merged commit 7999797 into main Oct 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant