Repository navigation
fix(pi): register jafar-perf's MCP server in the pi package - #10
Merged
Merged
Conversation
jafar-perf lived in btraceio/jafar-perf-box as a pi package whose manifest registered the plugin's .mcp.json (`pi.mcp`), so installing it into pi also brought the jafar MCP server. This repository's pi package listed skills only, so pi users moving here would get the skills with no server behind them. Add `pi.mcp: ./plugins/jafar-perf/.mcp.json`, and have validate-repository.js check that path exists like it does for the skills directories, so the entry cannot rot. Only jafar-perf's server is registered: jfr-analyzer's .mcp.json starts the same jfr-mcp daemon under another name, and pi would run two bridges for one server. Verified: pi-mcp-adapter's own package loader (package-mcp-loader.ts, run from a copy outside node_modules) is given this package installed into a scratch pi home. With the entry it registers `btraceio_agent-plugins__jafar` as `jbang jfr-mcp@btraceio --stdio --attach`; without it, which is what main has today, it registers no servers. scripts/validate-marketplace.sh passes, and the validator now fails on a `pi.mcp` pointing at a missing file. Not run: a live pi session calling a jafar tool through the adapter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
jafar-perfused to live inbtraceio/jafar-perf-boxas a pi package whose manifest registered the plugin's.mcp.json(pi.mcp), so installing it into pi also brought the jafar MCP server. This repository's pi package lists skills only. A pi user moving here (which is where jafar's installer is about to send them, see the companion PR) would get the skills with no server behind them.This adds
pi.mcp: ./plugins/jafar-perf/.mcp.jsontopackage.json, and makesvalidate-repository.jscheck that path exists, the way it already does for the skills directories, so the entry cannot rot.Only jafar-perf's server is registered.
pi.mcpalso accepts a list, butjfr-analyzer's.mcp.jsonstarts the samejfr-mcpdaemon under another name, and pi would run two bridges for one server. Registeringjafar-perf's alone is also what the old package did.How verified
scripts/validate-marketplace.shvalidate-repository.jswithpi.mcppointing at a missing filepi: missing MCP config ./plugins/jafar-perf/nope.jsonloadPackageMcpConfigs(run from a copy outsidenode_modules) against this package installed into a scratch pi homebtraceio_agent-plugins__jafar=jbang jfr-mcp@btraceio --stdio --attachmainhas today)Coverage notes
The loader run exercises the exact code pi's adapter uses to turn a package's
pi.mcpinto servers, on a realpi installof this branch. The validator change is covered by the negative case above.Not verified / known limitations
Why this is a draft: the live-session check above is missing. It flips to ready on your say-so; nothing else is open.
Breaking changes / migration
None. pi users who install this package now also get the jafar MCP server, as they did from the old repository.
Links
Companion: btraceio/jafar#120 (installer and docs repointed here), which should merge after this one. Part of moving
jafar-perf-boxusers here before that repository is archived.🤖 Generated with Claude Code