Skip to content

EM: remove 260 lines of shelved matching code from intake/router.py - #54

Closed
brooksRoley wants to merge 1 commit into
mainfrom
em/remove-dead-intake-matching-routes
Closed

brooksRoley wants to merge 1 commit into
mainfrom
em/remove-dead-intake-matching-routes

Conversation

@brooksRoley

Copy link
Copy Markdown
Owner

What

Removes all shelved psychometric-matching code from server/app/intake/router.py. Matching was shelved per CLAUDE.md Creative Direction; this dead code was flagged twice in the Running Notes ledger (flag_count: 2, owner: agent).

Deleted: GET /match (~180 lines)

The full user-matching pipeline: Pinecone nearest-user query, match_interactions table reads (both directions), Spotify/Twitter/Strava/Oracle overlap computation, and human-readable match-reason generation. Zero callers since matching was shelved. References find_nearest_users (Pinecone ANN), match_interactions table, and five helper functions below.

Deleted: 5 helper functions (~70 lines)

  • _build_match_reason — GPT-style match explanation from psychological coordinates
  • _extract_spotify_overlap — genre/artist/audio-feature comparison between two users
  • _extract_twitter_overlap — tweet-length and language comparison
  • _extract_strava_overlap — shared activity-type intersection
  • _extract_oracle_insight — oracle coordinate extraction for match display

Deleted: POST /fitting (~15 lines)

Saved fitting_self / fitting_ideal avatar JSON to vibe_vectors. Part of the shelved fitting-ritual / swipe flow (FittingView, RevealView — also shelved).

Updated: imports

  • Removed FittingRequest from .models import (model definition in models.py stays — it's harmless there)
  • Removed find_nearest_users from ..vector.service import (query_relevant_journal and upsert_user_vector remain — both used by POST /confess)

Kept: GET /vector and POST /confess

GET /vector returns the current user's own vibe vector (attachment style, defense mechanism, readiness score) — legitimately used by the psychoanalysis pipeline, not matching. Kept.

Verified

  • Opened server/app/intake/router.py on main (SHA: 0be6f0fd) today — confirmed GET /match queries find_nearest_users and match_interactions, both dead since matching was shelved.
  • POST /fitting writes fitting_self/fitting_ideal columns — shelved fitting ritual, no frontend consumers since PR Remove shelved matching routes and views (/game, /messages) #9.
  • No other file in the repo calls GET /intake/match or POST /intake/fitting (all routing was removed with the matching frontend in earlier PRs).

Net change

~260 lines deleted, 0 added. Router goes from ~370 → ~110 lines.

Livelihood stream

Code quality / portfolio signal — dead code creates cognitive overhead for contributors, misleads readers about what the product does, and inflates onboarding cost. Keeps the codebase honest about what's actually shipped.


Generated by Claude Code

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
channelzero Ready Ready Preview Aug 30, 2026 4:06pm

brooksRoley added a commit that referenced this pull request Sep 16, 2026
Removes GET /match + 5 match-reason helpers and the find_nearest_users
import (Pinecone vibe-vector matching, shelved). Preserves POST /fitting
(save_fitting) and the FittingRequest import — the fitting ritual is a
kept feature and FittingRitualView depends on this endpoint.

Supersedes #54, which also deleted POST /fitting and would have broken
the fitting ritual.

Claude-Session: https://claude.ai/code/session_01XQWPWCsbSJKJVqbgNtXbcs
brooksRoley added a commit that referenced this pull request Sep 16, 2026
Removes GET /match + 5 match-reason helpers and the find_nearest_users
import (Pinecone vibe-vector matching, shelved). Preserves POST /fitting
(save_fitting) and the FittingRequest import — the fitting ritual is a
kept feature and FittingRitualView depends on this endpoint.

Supersedes #54, which also deleted POST /fitting and would have broken
the fitting ritual.

Claude-Session: https://claude.ai/code/session_01XQWPWCsbSJKJVqbgNtXbcs
@brooksRoley

Copy link
Copy Markdown
Owner Author

Superseded by #69, which removes the same shelved /match matching code but preserves POST /fitting. #54 also deleted the fitting endpoint, which would break the fitting ritual (a kept feature — FittingRitualView depends on it).

@brooksRoley
brooksRoley deleted the em/remove-dead-intake-matching-routes branch September 16, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant