Skip to content

Prune matching-era dead code: /match endpoint, 2 views, LLMKeyManager, 2 routes - #68

Closed
brooksRoley wants to merge 4 commits into
mainfrom
staff/prune-matching-era-dead-code
Closed

brooksRoley wants to merge 4 commits into
mainfrom
staff/prune-matching-era-dead-code

Conversation

@brooksRoley

Copy link
Copy Markdown
Owner

What

Removes the last substantial block of matching-era dead code from main.

Backendserver/app/intake/router.py

  • Removes GET /match endpoint (Pinecone vibe-vector matching — shelved, never has paying users, requires unfunded embed key)
  • Removes 5 helper functions that only served /match: _build_match_reason, _extract_twitter_overlap, _extract_strava_overlap, _extract_oracle_insight, _extract_spotify_overlap (~160 lines total)
  • Removes find_nearest_users from the vector.service import (the only consumer was /match)
  • Keeps /confess, /vector, /fitting — all still active

Frontendsrc/router/index.ts

  • Removes /fitting/:matchId route → FittingRitualView (matching-era ritual, no product path)
  • Removes /reveal/:matchId route → RevealView (matching-era match reveal, no product path)
  • The standalone /fitting route (Fitting.vue) is untouched

Files deleted

  • src/views/FittingRitualView.vue (10 KB) — route removed above, zero callers remaining
  • src/views/RevealView.vue (18 KB) — route removed above, zero callers remaining
  • src/components/LLMKeyManager.vue (4.7 KB) — BYOK flow explicitly orphaned per CLAUDE.md; no imports found in any file

Why

The matching feature has been shelved since the Pinecone/embedding era. The embed key is intentionally unfunded. The router entries were the last thing keeping these views "alive" — removing routes + deleting files completes the cleanup and reduces the surface area that new engineers or agents might mistake for active product.

Supersedes PR #63 (which only removed the router entries, not the view files). You can close #63 once this lands.

Verification

  • src/router/index.ts: no remaining references to FittingRitualView or RevealView
  • server/app/intake/router.py: find_nearest_users removed from import; /match route and all helper functions removed; /confess, /vector, /fitting unchanged
  • LLMKeyManager.vue: confirmed zero imports across all src/ files before deletion

🤖 Generated with Claude Code

https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j


Generated by Claude Code

brooksRoley and others added 4 commits September 15, 2026 09:07
…reveal/:matchId routes, LLMKeyManager

- intake/router.py: remove GET /match + 5 helper fns + find_nearest_users import (shelved Pinecone matching, never routes to a real endpoint)
- src/router/index.ts: remove /fitting/:matchId + /reveal/:matchId routes (matching-era views with no product path)
- Supersedes PR #63 (router-only cleanup) — view file deletions in this PR

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
…d, no callers

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
channelzero Ready Ready Preview Sep 15, 2026 4:09pm UTC

@brooksRoley

Copy link
Copy Markdown
Owner Author

Closing: bundles good backend /match cleanup WITH deletion of LLMKeyManager.vue + fitting/reveal views+routes, which contradicts the standing decision to keep LLMKeyManager (BYOK) and fitting/reveal. The backend matching removal is covered cleanly by #54.

@brooksRoley
brooksRoley deleted the staff/prune-matching-era-dead-code branch September 15, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant