Prune matching-era dead code: /match endpoint, 2 views, LLMKeyManager, 2 routes - #68
Closed
brooksRoley wants to merge 4 commits into
Closed
brooksRoley wants to merge 4 commits into
brooksRoley wants to merge 4 commits into
Conversation
…reveal/:matchId routes, LLMKeyManager - intake/router.py: remove GET /match + 5 helper fns + find_nearest_users import (shelved Pinecone matching, never routes to a real endpoint) - src/router/index.ts: remove /fitting/:matchId + /reveal/:matchId routes (matching-era views with no product path) - Supersedes PR #63 (router-only cleanup) — view file deletions in this PR Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
…is PR Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
…d, no callers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Closing: bundles good backend /match cleanup WITH deletion of LLMKeyManager.vue + fitting/reveal views+routes, which contradicts the standing decision to keep LLMKeyManager (BYOK) and fitting/reveal. The backend matching removal is covered cleanly by #54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the last substantial block of matching-era dead code from main.
Backend —
server/app/intake/router.pyGET /matchendpoint (Pinecone vibe-vector matching — shelved, never has paying users, requires unfunded embed key)/match:_build_match_reason,_extract_twitter_overlap,_extract_strava_overlap,_extract_oracle_insight,_extract_spotify_overlap(~160 lines total)find_nearest_usersfrom thevector.serviceimport (the only consumer was/match)/confess,/vector,/fitting— all still activeFrontend —
src/router/index.ts/fitting/:matchIdroute →FittingRitualView(matching-era ritual, no product path)/reveal/:matchIdroute →RevealView(matching-era match reveal, no product path)/fittingroute (Fitting.vue) is untouchedFiles deleted
src/views/FittingRitualView.vue(10 KB) — route removed above, zero callers remainingsrc/views/RevealView.vue(18 KB) — route removed above, zero callers remainingsrc/components/LLMKeyManager.vue(4.7 KB) — BYOK flow explicitly orphaned per CLAUDE.md; no imports found in any fileWhy
The matching feature has been shelved since the Pinecone/embedding era. The embed key is intentionally unfunded. The router entries were the last thing keeping these views "alive" — removing routes + deleting files completes the cleanup and reduces the surface area that new engineers or agents might mistake for active product.
Supersedes PR #63 (which only removed the router entries, not the view files). You can close #63 once this lands.
Verification
src/router/index.ts: no remaining references toFittingRitualVieworRevealViewserver/app/intake/router.py:find_nearest_usersremoved from import;/matchroute and all helper functions removed;/confess,/vector,/fittingunchangedLLMKeyManager.vue: confirmed zero imports across allsrc/files before deletion🤖 Generated with Claude Code
https://claude.ai/code/session_01Le5Bo7HYQFmt35az5Q714j
Generated by Claude Code