Skip to content

build(deps): bump jvmreach-analyzer to v0.4.1, and unblock the local gates - #530

Merged
bomly-guy merged 3 commits into
mainfrom
claude/bump-jvmreach-v0.4.1
Oct 24, 2026
Merged

bomly-guy merged 3 commits into
mainfrom
claude/bump-jvmreach-v0.4.1

Conversation

@bomly-guy

@bomly-guy bomly-guy commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Three commits, meant to be read separately.

1. Bump bomly-plugin-jvmreach-analyzer to v0.4.1

v0.4.1 discovers a Maven or Gradle module in a directory whose name begins with two dots, such as the ..data of a Kubernetes Secret or ConfigMap mount, which v0.4.0 silently skipped (bomly-dev/bomly-plugin-jvmreach-analyzer#3, fixed in bomly-dev/bomly-plugin-jvmreach-analyzer#12). go get …@v0.4.1 && go mod tidy; no other module moves.

2. TestRoot_DiffCommand_AuditUsesResolvedGitRefs fails on main

The test runs the live grype and osv matchers against real npm packages and required a clean exit. GHSA-mrhx-c7xc-m3w5 (high, CVE-2023-54404) now matches zod@3.23.0, the default threshold fails the run, and the test fails with "1 finding matched the configured severity threshold" — on main too, with or without this bump.

The test is about the git refs the audit resolves, not the advisory set. It now accepts a policy-violation exit only when the audit payload holds a failing introduced or persisted finding to justify it; any other error, or a policy exit with nothing behind it, still fails. Every existing assertion (audit payload, changed manifests, SARIF) is kept.

3. Bump golangci-lint v2.13.2 → v2.15.0

v2.13.2 cannot type-check packages built by Go 1.27.2 (export data version 5 is greater than maximum supported version 4), so make lint and the pre-commit hook fail on every package on the current Go patch release. CI stayed green only because setup-go installs the go.mod floor, 1.27.0. v2.15.0 (x/tools 0.52.0) lints the tree with 0 issues, default and lite tags, from an empty cache. Pinned in the Makefile and both ci.yml steps.

Verification

Local, Go 1.27.2: pre-commit (fmt-check, guardcheck, golangci-lint ×2) passed on each commit; pre-push make test passed; go mod tidy -diff clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the linting tools and JVM reachability analyzer to newer versions.
  • Tests
    • Improved checks for audit command results, including policy-violation exit codes.

bomly-guy and others added 3 commits October 24, 2026 16:41
…sory

TestRoot_DiffCommand_AuditUsesResolvedGitRefs runs the live grype and
osv matchers against real npm packages and required the run to exit
cleanly, which held only while none of them carried a high advisory.
GHSA-mrhx-c7xc-m3w5 (CVE-2023-54404) now matches zod 3.23.0, the default
threshold fails the run, and the test fails on main.

The test is about the git refs the audit resolves, not the advisory set.
Accept a policy-violation exit, but only when the audit payload holds a
failing introduced or persisted finding to justify it; any other error,
or a policy exit with nothing behind it, still fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v2.13.2 cannot type-check packages built by Go 1.27.2 ("export data
version 5 is greater than maximum supported version 4"), so make lint and
the pre-commit hook fail on every package for anyone on the current Go
patch release. CI stayed green only because setup-go installs the
go.mod floor, 1.27.0. v2.15.0 carries golang.org/x/tools 0.52.0 and lints
the tree clean, default and lite build tags, from an empty cache.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.4.1 discovers a Maven or Gradle module in a directory whose name
begins with two dots, such as the "..data" of a Kubernetes Secret or
ConfigMap mount, which v0.4.0 silently skipped
(bomly-dev/bomly-plugin-jvmreach-analyzer#3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T23:45:32.117297Z cb6a7e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 956a91d and cb6a7e1.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 4
  • .github/workflows/ci.yml
  • Makefile
  • go.mod
  • internal/cli/root_cmd_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The CI workflow and Makefile now use golangci-lint v2.15.0. The JVM reachability analyzer dependency is upgraded to v0.4.1. The audit test accepts policy-violation exits when the audit contains failing introduced or persisted findings.

Changes: Lint tooling

Layer / File(s) Summary
Update lint tool version
.github/workflows/ci.yml, Makefile
Both CI lint steps and the Makefile now specify golangci-lint v2.15.0. The lint commands and build-tag arguments remain unchanged.

Analyzer and audit test

Layer / File(s) Summary
Update analyzer and audit assertions
go.mod, internal/cli/root_cmd_test.go
The JVM reachability analyzer dependency changes from v0.4.0 to v0.4.1. The audit test accepts only policy-violation errors and checks that their presence matches whether introduced or persisted findings have an empty or failing policy status.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to cb6a7

No actionable issue is established in these changes; the PR is ready for normal merge checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the dependency upgrade and accurately references the related local gate changes. It is concise and relevant to the pull request objectives.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread go.mod
github.com/bomly-dev/bomly-plugin-grype-matcher v0.7.0
github.com/bomly-dev/bomly-plugin-jsreach-analyzer v0.4.0
github.com/bomly-dev/bomly-plugin-jvmreach-analyzer v0.4.0
github.com/bomly-dev/bomly-plugin-jvmreach-analyzer v0.4.1
@github-actions

Copy link
Copy Markdown
Contributor

Bomly Diff Summary

Compared 956a91dd8880138a8d2a5ec8372b60f470684136 to cb6a7e1abf1fdb59749c32931f639268828f0960.

Overview

Status Manifests Dependencies Findings Duration
⚠️ Warnings +0 / ~1 / -0 0 added / 1 version changed / 0 detail changes / 0 removed 1 introduced / 0 persisted / 0 resolved 1m 38s

Dependency Changes

Summary: 0 added, 1 version changed, 0 detail changes, 0 removed.

Changed Dependencies

Change Package Version Direct? Scope Licenses
changed github.com/bomly-dev/bomly-plugin-jvmreach-analyzer v0.4.0 → v0.4.1 Yes runtime -

Vulnerabilities

✅ No vulnerability changes.

License Changes

Summary: 0 added, 1 changed, 0 removed.

Changed Licenses

Change Package Before After
changed github.com/bomly-dev/bomly-plugin-jvmreach-analyzer@v0.4.1 Apache-2.0 -

Project Posture

✅ No project posture changes (--matchers +scorecard was not selected).

Policy Findings

Summary: 1 introduced, 0 persisted, 0 resolved.

Introduced Findings

Status Category Severity ID Package Fixed In Title
⚠️ introduced license WARNING UNKNOWN-5up2-jtiw-nr5e github.com/bomly-dev/bomly-plugin-jvmreach-analyzer@v0.4.1 - Package license is unknown

Legend: ✅ resolved · ❌ failing · ⚠️ warning

@bomly-guy
bomly-guy merged commit c4d72db into main Oct 24, 2026
19 checks passed
@bomly-guy
bomly-guy deleted the claude/bump-jvmreach-v0.4.1 branch October 24, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants