Repository navigation
build(deps): bump jvmreach-analyzer to v0.4.1, and unblock the local gates - #530
Conversation
…sory TestRoot_DiffCommand_AuditUsesResolvedGitRefs runs the live grype and osv matchers against real npm packages and required the run to exit cleanly, which held only while none of them carried a high advisory. GHSA-mrhx-c7xc-m3w5 (CVE-2023-54404) now matches zod 3.23.0, the default threshold fails the run, and the test fails on main. The test is about the git refs the audit resolves, not the advisory set. Accept a policy-violation exit, but only when the audit payload holds a failing introduced or persisted finding to justify it; any other error, or a policy exit with nothing behind it, still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v2.13.2 cannot type-check packages built by Go 1.27.2 ("export data
version 5 is greater than maximum supported version 4"), so make lint and
the pre-commit hook fail on every package for anyone on the current Go
patch release. CI stayed green only because setup-go installs the
go.mod floor, 1.27.0. v2.15.0 carries golang.org/x/tools 0.52.0 and lints
the tree clean, default and lite build tags, from an empty cache.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.4.1 discovers a Maven or Gradle module in a directory whose name begins with two dots, such as the "..data" of a Kubernetes Secret or ConfigMap mount, which v0.4.0 silently skipped (bomly-dev/bomly-plugin-jvmreach-analyzer#3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update lint tool version .github/workflows/ci.yml, Makefile |
Both CI lint steps and the Makefile now specify golangci-lint v2.15.0. The lint commands and build-tag arguments remain unchanged. |
Analyzer and audit test
| Layer / File(s) | Summary |
|---|---|
Update analyzer and audit assertions go.mod, internal/cli/root_cmd_test.go |
The JVM reachability analyzer dependency changes from v0.4.0 to v0.4.1. The audit test accepts only policy-violation errors and checks that their presence matches whether introduced or persisted findings have an empty or failing policy status. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Merge Risk: 
Minimal · up to cb6a7
-
No actionable issue is established in these changes; the PR is ready for normal merge checks.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
| github.com/bomly-dev/bomly-plugin-grype-matcher v0.7.0 | ||
| github.com/bomly-dev/bomly-plugin-jsreach-analyzer v0.4.0 | ||
| github.com/bomly-dev/bomly-plugin-jvmreach-analyzer v0.4.0 | ||
| github.com/bomly-dev/bomly-plugin-jvmreach-analyzer v0.4.1 |
Bomly Diff SummaryCompared Overview
Dependency ChangesSummary: 0 added, 1 version changed, 0 detail changes, 0 removed. Changed Dependencies
Vulnerabilities✅ No vulnerability changes. License ChangesSummary: 0 added, 1 changed, 0 removed. Changed Licenses
Project Posture✅ No project posture changes ( Policy FindingsSummary: 1 introduced, 0 persisted, 0 resolved. Introduced Findings
|
Three commits, meant to be read separately.
1. Bump bomly-plugin-jvmreach-analyzer to v0.4.1
v0.4.1 discovers a Maven or Gradle module in a directory whose name begins with two dots, such as the
..dataof a Kubernetes Secret or ConfigMap mount, which v0.4.0 silently skipped (bomly-dev/bomly-plugin-jvmreach-analyzer#3, fixed in bomly-dev/bomly-plugin-jvmreach-analyzer#12).go get …@v0.4.1 && go mod tidy; no other module moves.2.
TestRoot_DiffCommand_AuditUsesResolvedGitRefsfails onmainThe test runs the live grype and osv matchers against real npm packages and required a clean exit. GHSA-mrhx-c7xc-m3w5 (high, CVE-2023-54404) now matches
zod@3.23.0, the default threshold fails the run, and the test fails with "1 finding matched the configured severity threshold" — onmaintoo, with or without this bump.The test is about the git refs the audit resolves, not the advisory set. It now accepts a policy-violation exit only when the audit payload holds a failing introduced or persisted finding to justify it; any other error, or a policy exit with nothing behind it, still fails. Every existing assertion (audit payload, changed manifests, SARIF) is kept.
3. Bump golangci-lint v2.13.2 → v2.15.0
v2.13.2 cannot type-check packages built by Go 1.27.2 (
export data version 5 is greater than maximum supported version 4), somake lintand the pre-commit hook fail on every package on the current Go patch release. CI stayed green only becausesetup-goinstalls thego.modfloor, 1.27.0. v2.15.0 (x/tools 0.52.0) lints the tree with 0 issues, default and lite tags, from an empty cache. Pinned in the Makefile and bothci.ymlsteps.Verification
Local, Go 1.27.2: pre-commit (
fmt-check, guardcheck,golangci-lint×2) passed on each commit; pre-pushmake testpassed;go mod tidy -diffclean.🤖 Generated with Claude Code
Summary by CodeRabbit