Repository navigation
build(lint): bump golangci-lint to v2.15.0 - #120
Conversation
golangci-lint v2.13.2 bundles a golang.org/x/tools too old to read the export data Go 1.27.2 writes (version 5; it supports 4), so every package fails to type-check locally. CI stayed green only because setup-go installs the go.mod floor (1.27.0). v2.15.0 lints the module with 0 issues from an empty cache on Go 1.27.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bomly Diff SummaryCompared Overview
Dependency Changes✅ No dependency changes. Vulnerabilities✅ No vulnerability changes. License Changes✅ No license changes. Project Posture✅ No project posture changes ( Policy Findings✅ No policy differences were identified. |
Bumps the pinned golangci-lint from v2.13.2 to v2.15.0 in both places it is pinned:
GOLANGCI_LINT_VERSIONin theMakefileand the golangci-lint-actionversion:in.github/workflows/ci.yml.Why
golangci-lint v2.13.2 cannot type-check packages built by Go 1.27.2. Every package fails with:
Its bundled
golang.org/x/toolsis too old to read the export data format Go 1.27.2 writes.Why CI stayed green
actions/setup-goreads thego.modfloor (go 1.27.0) and installs 1.27.0, whose export data v2.13.2 can still read. Locally the toolchain is 1.27.2, somake lintbroke there. A cached golangci-lint result can also hide the failure, so the verification below ran with an empty cache.bomly-cli made the same bump in bomly-dev/bomly-cli#530.
Verification (Go 1.27.2, golangci-lint 2.15.0)
GOLANGCI_LINT_CACHE=$(mktemp -d) golangci-lint run ./...→0 issues.No new findings from v2.15.0.make test,make vet,make fmt-checkall pass.🤖 Generated with Claude Code