Apply password during onboarding and prompt for password when needed

.github/workflows/gui-functional-tests.yml

@@ -16,6 +16,8 @@ on:
 jobs:
   qml-functional-tests:
     runs-on: ubuntu-24.04
+    env:
+      LEGACY_BITCOIND_VERSION: "28.0"
 
     steps:
       - name: Checkout
@@ -27,7 +29,7 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y \
-            build-essential cmake pkgconf python3 \
+            build-essential cmake curl pkgconf python3 \
             libevent-dev libboost-dev libsqlite3-dev libgl-dev libqrencode-dev \
             qt6-qpa-plugins \
             qt6-base-dev qt6-tools-dev qt6-l10n-tools qt6-tools-dev-tools \
@@ -37,6 +39,47 @@ jobs:
             qml6-module-qtquick-layouts qml6-module-qtquick-controls \
             qml6-module-qtquick-dialogs qml6-module-qtquick-templates
 
+      - name: Restore legacy bitcoind cache
+        uses: actions/cache/restore@v4
+        id: legacy-bitcoind-cache
+        with:
+          path: releases/v${{ env.LEGACY_BITCOIND_VERSION }}
+          key: ${{ runner.os }}-legacy-bitcoind-v${{ env.LEGACY_BITCOIND_VERSION }}
+
+      - name: Install legacy bitcoind
+        run: |
+          archive="bitcoin-${LEGACY_BITCOIND_VERSION}-x86_64-linux-gnu.tar.gz"
+          base_url="https://bitcoincore.org/bin/bitcoin-core-${LEGACY_BITCOIND_VERSION}"
+          legacy_dir="${GITHUB_WORKSPACE}/releases/v${LEGACY_BITCOIND_VERSION}"
+
+          mkdir -p "${legacy_dir}"
+
+          if [ ! -x "${legacy_dir}/bin/bitcoind" ]; then
+            workdir="$(mktemp -d)"
+            trap 'rm -rf "${workdir}"' EXIT
+
+            curl -fsSLo "${workdir}/${archive}" "${base_url}/${archive}"
+            curl -fsSLo "${workdir}/SHA256SUMS" "${base_url}/SHA256SUMS"
+            (
+              cd "${workdir}"
+              grep " ${archive}$" "SHA256SUMS" | sha256sum -c -
+            )
+
+            tar -xzf "${workdir}/${archive}" \
+              --strip-components=1 \
+              -C "${legacy_dir}" \
+              "bitcoin-${LEGACY_BITCOIND_VERSION}/bin"
+          fi
+
+          "${legacy_dir}/bin/bitcoind" --version | head -n 1
+
+      - name: Save legacy bitcoind cache
+        uses: actions/cache/save@v4
+        if: github.event_name != 'pull_request' && steps.legacy-bitcoind-cache.outputs.cache-hit != 'true'
+        with:
+          path: releases/v${{ env.LEGACY_BITCOIND_VERSION }}
+          key: ${{ runner.os }}-legacy-bitcoind-v${{ env.LEGACY_BITCOIND_VERSION }}
+
       - name: Configure
         run: |
           cmake -B build \
@@ -53,10 +96,17 @@ jobs:
           QT_QUICK_BACKEND: software
           LIBGL_ALWAYS_SOFTWARE: "1"
         run: |
+          export BITCOIND_LEGACY="${GITHUB_WORKSPACE}/releases/v${LEGACY_BITCOIND_VERSION}/bin/bitcoind"
           python3 test/functional/qml_test_bridge_sanity.py
           python3 test/functional/qml_test_onboarding.py
           python3 test/functional/qml_test_external_signer.py
           python3 test/functional/qml_test_peers.py
           python3 test/functional/qml_test_proxy.py
           python3 test/functional/qml_test_debug_log.py
           python3 test/functional/qml_test_settings_display.py
+          python3 test/functional/qml_test_password_wallet.py
+          python3 test/functional/qml_test_send_receive.py
+          python3 test/functional/qml_test_send_review.py
+          python3 test/functional/qml_test_wallet_migration.py
+          python3 test/functional/qml_test_wallet_rbf.py
+          python3 test/functional/qml_test_wallet_restore.py

qml/bitcoin_qml.qrc

@@ -30,6 +30,8 @@
         <file>components/Tooltip.qml</file>
         <file>components/LabeledValueField.qml</file>
         <file>components/WalletSettings.qml</file>
+        <file>components/WalletMigrationPopup.qml</file>
+        <file>components/WalletPassphrasePopup.qml</file>
         <file>controls/AddWalletButton.qml</file>
         <file>controls/CaretRightIcon.qml</file>
         <file>controls/ContinueButton.qml</file>
@@ -107,6 +109,7 @@
         <file>pages/wallet/CreatePassword.qml</file>
         <file>pages/wallet/ImportWalletOptions.qml</file>
         <file>pages/wallet/ImportWalletSuccess.qml</file>
+        <file>pages/wallet/ImportWalletMigration.qml</file>
         <file>pages/wallet/CreateWalletWizard.qml</file>
         <file>pages/wallet/DesktopWallets.qml</file>
         <file>pages/wallet/MultipleSendReview.qml</file>

qml/components/WalletMigrationPopup.qml

@@ -0,0 +1,107 @@
+// Copyright (c) 2026 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+import QtQuick 2.15
+import QtQuick.Controls 2.15
+import QtQuick.Layouts 1.15
+
+import "../controls"
+
+Popup {
+    id: root
+
+    property string popupObjectName: ""
+    property string titleText: qsTr("Wallet update required")
+    property string descriptionText: ""
+    property string confirmText: qsTr("Update wallet")
+    property string busyConfirmText: qsTr("Updating...")
+    property string errorText: ""
+    property string errorTextObjectName: ""
+    property string cancelButtonObjectName: ""
+    property string confirmButtonObjectName: ""
+    property bool busy: false
+
+    signal confirmed()
+
+    objectName: popupObjectName
+    modal: true
+    padding: 0
+    implicitWidth: 420
+    implicitHeight: columnLayout.implicitHeight
+    anchors.centerIn: parent
+
+    background: Rectangle {
+        color: Theme.color.background
+        radius: 10
+        border.color: Theme.color.neutral4
+        border.width: 1
+    }
+
+    ColumnLayout {
+        id: columnLayout
+        anchors.fill: parent
+        spacing: 0
+
+        CoreText {
+            Layout.fillWidth: true
+            Layout.preferredHeight: 56
+            text: root.titleText
+            bold: true
+            font.pixelSize: 24
+            horizontalAlignment: Text.AlignHCenter
+            verticalAlignment: Text.AlignVCenter
+        }
+
+        Separator {
+            Layout.fillWidth: true
+        }
+
+        Header {
+            Layout.fillWidth: true
+            Layout.margins: 20
+            Layout.topMargin: 20
+            header: root.descriptionText
+            headerBold: false
+            headerSize: 16
+        }
+
+        CoreText {
+            objectName: root.errorTextObjectName
+            Layout.fillWidth: true
+            Layout.leftMargin: 20
+            Layout.rightMargin: 20
+            Layout.topMargin: 4
+            visible: text.length > 0
+            text: root.errorText
+            color: Theme.color.red
+            font.pixelSize: 15
+            wrapMode: Text.WordWrap
+        }
+
+        RowLayout {
+            Layout.fillWidth: true
+            Layout.margins: 20
+            Layout.topMargin: 20
+            spacing: 15
+
+            OutlineButton {
+                objectName: root.cancelButtonObjectName
+                Layout.fillWidth: true
+                Layout.minimumWidth: 120
+                enabled: !root.busy
+                text: qsTr("Cancel")
+                onClicked: root.close()
+            }
+
+            ContinueButton {
+                objectName: root.confirmButtonObjectName
+                Layout.fillWidth: true
+                Layout.minimumWidth: 120
+                enabled: !root.busy
+                text: root.busy ? root.busyConfirmText : root.confirmText
+                onClicked: root.confirmed()
+            }
+        }
+    }
+}

qml/components/WalletPassphrasePopup.qml

@@ -0,0 +1,123 @@
+// Copyright (c) 2026 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+import QtQuick 2.15
+import QtQuick.Controls 2.15
+import QtQuick.Layouts 1.15
+
+import "../controls"
+
+Popup {
+    id: root
+
+    property string popupObjectName: ""
+    property string titleText: qsTr("Enter wallet password")
+    property string descriptionText: ""
+    property string confirmText: qsTr("Continue")
+    property string busyConfirmText: qsTr("Working...")
+    property string errorText: ""
+    property string passphraseFieldObjectName: ""
+    property string errorTextObjectName: ""
+    property string cancelButtonObjectName: ""
+    property string confirmButtonObjectName: ""
+    property bool busy: false
+
+    signal submitted(string passphrase)
+
+    objectName: popupObjectName
+    modal: true
+    padding: 0
+    implicitWidth: 420
+    implicitHeight: columnLayout.implicitHeight
+    anchors.centerIn: parent
+
+    onOpened: {
+        passphraseField.text = ""
+        passphraseField.forceActiveFocus()
+    }
+
+    background: Rectangle {
+        color: Theme.color.background
+        radius: 10
+        border.color: Theme.color.neutral4
+        border.width: 1
+    }
+
+    ColumnLayout {
+        id: columnLayout
+        anchors.fill: parent
+        spacing: 0
+
+        CoreText {
+            Layout.fillWidth: true
+            Layout.preferredHeight: 56
+            text: root.titleText
+            bold: true
+            font.pixelSize: 24
+            horizontalAlignment: Text.AlignHCenter
+            verticalAlignment: Text.AlignVCenter
+        }
+
+        Separator {
+            Layout.fillWidth: true
+        }
+
+        Header {
+            Layout.fillWidth: true
+            Layout.margins: 20
+            Layout.topMargin: 20
+            header: root.descriptionText
+            headerBold: false
+            headerSize: 16
+        }
+
+        CoreTextField {
+            id: passphraseField
+            objectName: root.passphraseFieldObjectName
+            Layout.fillWidth: true
+            Layout.leftMargin: 20
+            Layout.rightMargin: 20
+            hideText: true
+            placeholderText: qsTr("Enter password...")
+        }
+
+        CoreText {
+            objectName: root.errorTextObjectName
+            Layout.fillWidth: true
+            Layout.leftMargin: 20
+            Layout.rightMargin: 20
+            Layout.topMargin: 12
+            visible: text.length > 0
+            text: root.errorText
+            color: Theme.color.red
+            font.pixelSize: 15
+            wrapMode: Text.WordWrap
+        }
+
+        RowLayout {
+            Layout.fillWidth: true
+            Layout.margins: 20
+            Layout.topMargin: 20
+            spacing: 15
+
+            OutlineButton {
+                objectName: root.cancelButtonObjectName
+                Layout.fillWidth: true
+                Layout.minimumWidth: 120
+                enabled: !root.busy
+                text: qsTr("Cancel")
+                onClicked: root.close()
+            }
+
+            ContinueButton {
+                objectName: root.confirmButtonObjectName
+                Layout.fillWidth: true
+                Layout.minimumWidth: 120
+                enabled: !root.busy && passphraseField.text.length > 0
+                text: root.busy ? root.busyConfirmText : root.confirmText
+                onClicked: root.submitted(passphraseField.text)
+            }
+        }
+    }
+}