Apply password during onboarding and prompt for password when needed#548
Open
johnny9 wants to merge 10 commits into
Open
Apply password during onboarding and prompt for password when needed#548johnny9 wants to merge 10 commits into
johnny9 wants to merge 10 commits into
Conversation
fa75e31 to
4863b3e
Compare
Collaborator
Author
|
Cleaned up the commits and added unittest coverage |
89b5190 to
6d3488a
Compare
MarnixCroes
reviewed
May 11, 2026
Contributor
MarnixCroes
left a comment
There was a problem hiding this comment.
at migration, the dialog always shows up with error
Screencast.from.2026-05-11.10-55-04.webm
Collaborator
Author
Removed the error message from showing on the first prompt |
Collaborator
Author
In an attempt to improve on the signing flow I made the process too fragile. I have reverted back to a simpler design that aligns with the current Qt widgets flow. It should now correctly prompt and sign before moving to the review page. Then the review page will broadcast that prepared transaction when send is pressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #517