Skip to content

Apply password during onboarding and prompt for password when needed#548

Open
johnny9 wants to merge 10 commits into
bitcoin-core:qt6from
johnny9:wallet-password
Open

Apply password during onboarding and prompt for password when needed#548
johnny9 wants to merge 10 commits into
bitcoin-core:qt6from
johnny9:wallet-password

Conversation

@johnny9
Copy link
Copy Markdown
Collaborator

@johnny9 johnny9 commented Apr 15, 2026

image

Closes #517

@johnny9 johnny9 force-pushed the wallet-password branch 2 times, most recently from fa75e31 to 4863b3e Compare April 15, 2026 18:55
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented Apr 15, 2026

Cleaned up the commits and added unittest coverage

@johnny9 johnny9 force-pushed the wallet-password branch 5 times, most recently from 89b5190 to 6d3488a Compare May 9, 2026 15:24
@johnny9 johnny9 force-pushed the wallet-password branch from 6d3488a to 07e88a8 Compare May 11, 2026 12:41
Copy link
Copy Markdown
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

07e88a8

at migration, the dialog always shows up with error

Screencast.from.2026-05-11.10-55-04.webm

@johnny9 johnny9 force-pushed the wallet-password branch from 07e88a8 to fa67236 Compare May 11, 2026 21:17
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented May 11, 2026

07e88a8

at migration, the dialog always shows up with error
Screencast.from.2026-05-11.10-55-04.webm

Removed the error message from showing on the first prompt

@MarnixCroes
Copy link
Copy Markdown
Contributor

fa67236

The password prompt does not show up on the send flow. Just throws an error.

image

@johnny9 johnny9 force-pushed the wallet-password branch from fa67236 to 3135d62 Compare May 12, 2026 14:30
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented May 12, 2026

The password prompt does not show up on the send flow. Just throws an error.

In an attempt to improve on the signing flow I made the process too fragile. I have reverted back to a simpler design that aligns with the current Qt widgets flow. It should now correctly prompt and sign before moving to the review page. Then the review page will broadcast that prepared transaction when send is pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy Wallet Migration Flow

3 participants