Add the governance gate; move to the shared workflow tag - #2
Merged
Conversation
REPO-R1 requires every repository to call the shared governance gate. This one called hygiene, security, sign-off, commit lint, the reference comment and the labeler — but not the gate itself, so a change here could merge citing nothing. The reusable calls move from commit pins to the v1 tag, per ADR-0021: v1 moves forward as fixes merge in the spec repo, and a breaking change to a calling interface cuts v2 so this repo migrates deliberately rather than failing the moment something lands there. spec-references is now skipped for fork pull requests, whose token cannot write the comment it exists to post. Spec: REPO-R1, REPO-R7 Signed-off-by: Wessel Verheij <info@nightworks.io>
REPO-R5 requires every repository to carry an ownership file generated from the maintainer registry. This one had none, so no path had a declared owner and the triage workflow's assignee lookup had nothing to read. Spec: REPO-R5 Signed-off-by: Wessel Verheij <info@nightworks.io>
📎 Spec referencesThis PR cites the following spec identifiers:
Updated automatically on each push. |
Two of the shared checks have been running against this repository without the configuration they need, and failing on every pull request. The auto-labeler had no `.github/labeler.yml`, so it 404'd looking for one rather than labelling anything. The map is added, pointing this repo's paths at the canonical label set. The spell-checker was reading the Dutch half of the site as a wall of typos. Those files are excluded rather than allow-listed word by word: adding fifty Dutch words to an English dictionary would make the checker useless for the English copy it exists to protect. Spec: GOV-R12 Signed-off-by: Wessel Verheij <info@nightworks.io>
The dependency scanner reports nineteen known vulnerabilities against the pinned Astro version, five of them rated high. Clearing all of them needs 7.1.x, which is two majors ahead of where this sat. Taken in one step rather than staged, because the intermediate versions each leave some of the nineteen open and there is no partial state worth landing. Verified: `astro check` reports zero errors across 69 files, and the site builds all 33 pages. Spec: GOV-R12 Signed-off-by: Wessel Verheij <info@nightworks.io>
Astro 7 requires Node 22.12 or newer. The workflows pinned 20 and the `.nvmrc` said the same, so the upgrade type-checked and built locally on a newer runtime while failing in CI — the gap the `.nvmrc` exists to close. Both workflows and the version file move together, so a contributor running `nvm use` gets what CI runs. Spec: GOV-R12 Signed-off-by: Wessel Verheij <info@nightworks.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: REPO-R1, REPO-R5, REPO-R7, GOV-R12
The gate was missing
REPO-R1requires every repository to call the shared governance gate. This onecalled hygiene, security, sign-off, commit lint, the reference comment and the
labeler — but not the gate itself, so a change here could merge citing nothing.
Shared calls move to
@v1Per ADR-0021:
v1moves forward as fixes merge in the spec repository, so a shared fix stillpropagates in one merge, but a breaking change to a calling interface cuts
v2and this repository migrates deliberately rather than failing the moment
something lands there.
spec-referencesis now skipped for fork pull requests, whose token cannotwrite the comment it exists to post.
CODEOWNERS
REPO-R5requires an ownership file generated from the maintainer registry.This repository had none, so no path had a declared owner and the triage
workflow's assignee lookup had nothing to read.
Pre-existing failures fixed
Turning the full gate on surfaced three failures that were already there:
.github/labeler.yml, so the action 404'd on every run.Requires beatrax-app/spec#1, merged and tagged
v1.