[9.2.0] Verify the whole blob when downloading chunks (#29435) (#29593)#29615
Open
iancha1992 wants to merge 1 commit into
Open
[9.2.0] Verify the whole blob when downloading chunks (#29435) (#29593)#29615iancha1992 wants to merge 1 commit into
iancha1992 wants to merge 1 commit into
Conversation
…) (bazelbuild#29593) bazelbuild#29588 fails CI. This fixes it. This is a bug fix for the chunking implementation, where we should verify the hash of the full blob if verify downloads is specified, so we don't blindly trust SplitBlob responses.
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29588 fails CI. This fixes it.
This is a bug fix for the chunking implementation, where we should verify the hash of the full blob if verify downloads is specified, so we don't blindly trust SplitBlob responses.
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit 37237ad