[9.2.0] Verify the whole blob when downloading chunks (https://github.com/bazelbuild/bazel/pull/29435)#29514
Closed
bazel-io wants to merge 2 commits into
Closed
[9.2.0] Verify the whole blob when downloading chunks (https://github.com/bazelbuild/bazel/pull/29435)#29514bazel-io wants to merge 2 commits into
bazel-io wants to merge 2 commits into
Conversation
This is a bug fix for the chunking implementation, where we should verify the hash of the full blob if verify downloads is specified, so we don't blindly trust SplitBlob responses. Closes bazelbuild#29435. PiperOrigin-RevId: 913555501 Change-Id: I7ffd600e53e585ad946f15c89201382343992d7e
02f2453 to
c2bcf3a
Compare
Member
|
Closing in favor of: #29615 |
auto-merge was automatically disabled
May 21, 2026 19:10
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix for the chunking implementation, where we should verify the hash of the full blob if verify downloads is specified, so we don't blindly trust SplitBlob responses.
Closes #29435.
PiperOrigin-RevId: 913555501
Change-Id: I7ffd600e53e585ad946f15c89201382343992d7e
Commit e87f54e