refactor(core): delete dead post-seam compatibility shims#1112
Merged
Conversation
Three leftovers from the protocol-seam migration were traps for readers with zero production impact: - deps.py: shadowed by the deps/ package, so the module was unreachable dead code (the package __init__ is the live re-export surface) - basic_memory/cloud/: compat re-export package with no production importers here or in basic-memory-cloud main (already migrated to canonical basic_memory.services/index paths) - mcp/async_client.create_client(): deprecated sync path with zero callers; get_client() is the only client entrypoint Drop the cloud-package parity test and the now-moot import-boundary guard along with the package. Part of #1107 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of #1107 (2026-07 architecture review post-seam cleanup) — the deletions that are provably dead:
src/basic_memory/deps.py— the deprecated shim file was shadowed by thedeps/package (a package wins over a same-named module), so it was unreachable dead code. Everyfrom basic_memory.deps import ...resolves to the package__init__, which stays.src/basic_memory/cloud/— compat re-export package (5 one-line shims + barrel). Zero production importers in this repo (enforced by the boundary guard test) and zero in basic-memory-cloud's main tree — its imports were already migrated to canonicalbasic_memory.services/basic_memory.indexpaths. Only gateway README references remain there (doc touch-up, tracked separately).mcp/async_client.create_client()— deprecated sync client path with zero callers anywhere;get_client()is the only client entrypoint.Test changes: dropped the
basic_memory.cloudparity test and the now-moot cloud import-boundary guard; the rest oftests/cloud/test_cloud_services.py(canonical-service tests) is unchanged.Remaining #1107 items (legacy_router policy call, naming twins) are reported on the issue — they need decisions, not deletions.
Test plan
uv run pytest tests/cloud/test_cloud_services.py tests/test_architecture_boundaries.py tests/mcp/test_async_client_modes.py tests/test_deps.py— 57 passedjust typecheck— clean (9 pre-existing uvloop deprecation warnings only)ruff check— cleanPart of #1107
🤖 Generated with Claude Code