docs(core): refresh ARCHITECTURE.md after the arch-review cleanup#1115
Merged
Conversation
The 2026-07 arch-review PRs (#1111-#1114) made several sections stale: - the deps.py backwards-compat shim section described a file deleted in #1112; replaced with the shims-are-transitional principle - the router usage example imported v1 providers deleted in #1113; updated to the external-id providers and documented the new composition-root config injection from #1114 - the cloud/ compat package bullet described a package deleted in #1112 - the SyncCoordinator section and /sync directory entries described a package that no longer exists; replaced with the WatchCoordinator lifecycle that actually runs, and added index/, indexing/, and runtime/ to the directory listings - file-organization tree fixes: api/v2/routers, runtime/mode.py Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the merged arch-review PRs (#1111–#1114), which made parts of
docs/ARCHITECTURE.mddescribe deleted code:deps.py,basic_memory.cloud, andcreate_client()in refactor(core): delete dead post-seam compatibility shims #1112)get_entity_service/get_project_configproviders deleted in refactor(api): collapse dead v1/_v2 DI provider tiers #1113 → now shows the external-id providers, plus a new Config Injection section documenting the refactor(api): inject config from composition roots into the DI graph #1114 pattern (get_app_configreadsapp.state.container;resolve_container()covers the CLI/MCP ASGI flow; tests override the provider)cloud/package bullet removed from Runtime Package Boundaries (deleted in refactor(core): delete dead post-seam compatibility shims #1112)/syncdirectory entries described a package that no longer exists (predates this campaign — flagged as stale-docs in the review) → replaced with the actualWatchCoordinatorlifecycle, andindex/,indexing/,runtime/added to the directory listings in ARCHITECTURE.md and AGENTS.mdapi/v2/routers/,runtime/mode.pyDoc-only change.
🤖 Generated with Claude Code