Repository navigation
ci: refresh Base v1.10 candidate pin - #335
Conversation
codeforester
left a comment
codeforester
left a comment
There was a problem hiding this comment.
Reviewed head 3d57f7b against #324. No code findings. I confirmed the new advisory pin 06715fed… is a real Base main commit (the #2479 merge). Both scenario lanes pass on it (stable-v1.9 and advisory-v1.10-candidate), and every candidate doc link moves to the same revision. The drift test ties the workflow pin to the three docs.
CI: validate and validate-ubuntu fail only on the undici audit advisory (GHSA-3wwx-pv8p-q78v). That's #334/#338, not this change. Refresh after #338 merges.
Nits: (1) assertNotEqual(candidate, "5f316ae…") hard-codes the previous pin and becomes meaningless after the next refresh. Asserting that the docs contain only the workflow's candidate SHA (no other 40-hex Base blob SHAs) would catch partial updates generally. (2) Base main is already one commit past the pin (#2478, ruleset reconciliation). That's irrelevant to these scenarios, but it's worth re-pinning at the final v1.10.0 candidate.
3d57f7b to
4dcd38b
Compare
4dcd38b to
ced333c
Compare
|
Re-verified at One note (non-blocking for an advisory lane): despite the |
## Summary Remove stale Base 1.8.0/demo 0.1.0 claims from the capability matrix and dependency-inputs guide. Clarify that the stable demo contract is Base 1.9.0/demo v0.2.0, while the exact Base v1.10.0 candidate lane is advisory until the release and final BOM are verified. ## Issue Fixes #325 ## Validation - `python3 tests/validate_capability_matrix.py` (11 rows; passed) - `git diff --check` - Hosted validation is required on the stacked candidate-pin base. ## Notes This PR is intentionally stacked on the candidate-pin PR #335. Historical release records, including `docs/v0.2.0-readiness.md`, remain unchanged.
## Summary Extend the advisory Base v1.10 workspace scenario with disposable Git fixtures for the new `workspace update` safety contract. The scenario now proves that dry-run JSON rejects dirty checkouts, manifest paths nested inside an ancestor checkout, and clean default branches tracking the wrong upstream branch, without changing the checkout. Update the scenario guide and capability matrix to describe the coverage. ## Issue Fixes #327 ## Validation - `python3 tests/scenarios/workspace.py --base /private/tmp/base-candidate-06715 --base-commit 06715fed19aceff27844aba546ba2a0b4c594ac7 --base-cli /private/tmp/base-cli-8a93 --bash-libs /private/tmp/base-bash-libs-36fec --python /opt/homebrew/bin/python3 --candidate` (all scenario groups passed) - `python3 tests/scenario_harness_test.py` (2 passed) - `python3 tests/validate_capability_matrix.py` (11 rows; passed) - `git diff --check` - Hosted `scenarios` workflow is required on the stacked train. ## Notes This PR is stacked on documentation PR #336, which is stacked on candidate-pin PR #335. The fixtures are temporary and local; no learner checkout, trust store, or host workspace is modified.
Summary
Refresh the advisory Base v1.10 candidate lane to the current exact Base main commit
06715fed19aceff27844aba546ba2a0b4c594ac7. Update all candidate documentation links to the same immutable revision and add a regression test that prevents workflow/docs pin drift. The stable Base 1.9.0 dependency pin is unchanged.Issue
Fixes #324
Validation
python3 tests/dependency_inputs_test.py(4 passed)git diff --checkscenariosworkflow is required to validate both stable and advisory candidate lanes.Notes
The candidate ref is intentionally the current Base
origin/maincommit, not a v1.10.0 tag, because Base v1.10.0 has not shipped yet. The stable lane remains the released v1.9.0 contract.