Skip to content

Test opaque header for iOS Safari navigation flicker #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aurorascharff wants to merge 1 commit into from
Closed

Test opaque header for iOS Safari navigation flicker #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions src/components/Layout/TopNav/TopNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export default function TopNav({
const asPath = usePathname() || '/';
const [openMenuPath, setOpenMenuPath] = useState<string | null>(null);
const [showSearch, setShowSearch] = useState(false);
const [isScrolled, setIsScrolled] = useState(false);
const scrollParentRef = useRef<HTMLDivElement>(null);
// Deriving from the path hides the menu as soon as a navigation commits.
// Forget the path afterwards, so going Back doesn't reopen the menu.
Expand Down Expand Up @@ -211,24 +210,6 @@ export default function TopNav({
};
}, []);

const scrollDetectorRef = useRef(null);
useEffect(() => {
const observer = new IntersectionObserver(
(entries) => {
entries.forEach((entry) => {
setIsScrolled(!entry.isIntersecting);
});
},
{
root: null,
rootMargin: `0px 0px`,
threshold: 0,
}
);
observer.observe(scrollDetectorRef.current!);
return () => observer.disconnect();
}, []);

const onOpenSearch = useCallback(() => {
startTransition(() => {
setShowSearch(true);
Expand All @@ -245,7 +226,6 @@ export default function TopNav({
onOpen={onOpenSearch}
onClose={onCloseSearch}
/>
<div ref={scrollDetectorRef} />
<div
className={cn(
isMenuOpen
Expand All @@ -254,8 +234,8 @@ export default function TopNav({
)}>
<nav
className={cn(
'duration-300 backdrop-filter backdrop-blur-lg backdrop-saturate-200 transition-shadow bg-opacity-90 items-center w-full flex justify-between bg-wash dark:bg-wash-dark dark:bg-opacity-95 px-1.5 lg:pe-5 lg:ps-4 z-40',
{'dark:shadow-nav-dark shadow-nav': isScrolled || isMenuOpen}
'items-center w-full flex justify-between bg-wash dark:bg-wash-dark px-1.5 lg:pe-5 lg:ps-4 z-40',
isMenuOpen && 'dark:shadow-nav-dark shadow-nav'
)}>
<div className="flex items-center justify-between w-full h-16 gap-0 sm:gap-3">
<div className="flex flex-row 3xl:flex-1 items-centers">
Expand Down
Loading