Repository navigation
mfd: macsmc: Add T6050 profile and described pcIO outputs - #247
Closed
DjDeveloperr wants to merge 1 commit into
Closed
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
Expose notifications and described hwmon inputs on T6050. Register the pcIO GPIO provider only where DT supplies unique command templates, and validate the writable key and complete eight-byte writes. Preserve existing GPIO implementations and newer notification cleanup. Do not instantiate unqualified T6050 power, reboot or RTC functions. Signed-off-by: Dj <hey@djdev.me>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the T6050 SMC notification/hwmon profile and a DT-described pcIO output GPIO provider. Each GPIO uses a unique eight-byte command template supplied by the boot producer, with its low 16 bits reserved for the boolean output value. The driver checks the key's size/write capability, validates templates before registration, and rejects short writes. Readback is explicitly unsupported.
Register the pcIO child only when described in DT, on any matched SMC. Keep the inherited GPIO implementations and newer notification cleanup intact. The T6050 profile does not instantiate unqualified power/reboot/RTC functions or import the private temperature-discovery logger.
Validation: native arm64 SMC/GPIO driver objects, new/updated binding validation and whitespace checks passed. Firmware notification and output behavior still need hardware qualification of this cleaned series. No GPU changes.
Stacked on #246 for review ordering; the SMC driver itself does not depend on the new RTC driver.