Repository navigation
Conversation
Describe the existing four-range format used by the T8122 router. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Read target, actual, busy and automatic state after release. Do not override shared votes; let the caller quarantine restart when power-off is unproven. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Keep the two J613 ECAM windows in disjoint 32-vector slices of the ADT AIC window. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Use RUN with explicit pre-RTKit LSTX and strict firmware readiness; disable DP tunnelling. Own power references and require a witnessed off boundary before restart. Order PD, NHI and role/PHY shutdown. Keep the T8122 session coordinator scoped to J613. The sequence was inferred from the T6030 generation, not a J613 macOS restart trace, then exercised on J613 hardware. Suspend coordination is carried from the trial but is not hardware qualified; sleep remains outside admission. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Use saved J613 ADT windows, interrupts and tuning. Populate the root tunnel containers dynamically and include them only on J613. Own all four ACIO domains. Drop the disabled unused OTG node whose shared PHY/DARTs older Stage 2 loaders otherwise prune. Both J613 firmware profiles inherit the repair. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Compile the production function with missing and foreign domains, regmap errors and each status bit independently injected. Extract provider masks rather than duplicating register constants. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
Use one aperture selector for PCIe-C admission and its negative tests. Reject unknown apertures rather than borrowing another bridge slice. Signed-off-by: Satya Benson <satya@benson.earth> Assisted-by: LLM
The Apple NHI driver calls tb_apple_sleep_quiesce() from the Thunderbolt core. With CONFIG_USB4=m and CONFIG_USB4_APPLE_SOC=m, these are separate modules and modpost rejects thunderbolt_apple.ko with an undefined symbol. Export the existing helper to GPL modules so the modular configuration links. No quiesce behavior or hardware register access changes. Validated with the J613 production configuration, LLVM 18 Image/modules/ DTBs build and modpost, plus strict checkpatch. Assisted-by: LLM Signed-off-by: Satya Benson <satya@benson.earth>
Preserve original contributor commits and newer integration changes. Resolve only the overlapping shared-driver conditions/fields, retaining both the PR safety gates and the newer main behavior. Hardware qualification holds remain unchanged.
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
Resolved the current integration overlap mechanically and preserved original commits: apple_cio_hw keeps both newer dpin_count and strict_power_cycle. Existing PMGR witness/MSI-selector host tests and changed-Python syntax passed; broad CI reruns on this immutable head. This remains draft. The installed legacy Stage2 handoff still lacks the named cpu/MxWrap resource required by the new policy; a reviewed compatibility adapter or separately authorized attended DT-bundle path is still needed before kernel-only rollout there. Do not bypass the resource or power/reset admission checks. Current-head both-port/orientation/replug/no-cable/USB2-3/sleep and modular linkage/schema gates remain. Ref sent to ryan-orch-regress for other-generation regressions after CI; this does not prove the new J613 USB4 path.
Both targeted retries failed before validation in Ubuntu apt DNS bootstrap. Use Ubuntu's signed HTTPS archive/security mirror list on the ephemeral runner and fail apt update on repository errors. Keep test/toolchain, permissions, job limits and driver/DT source unchanged.
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
Both targeted retries failed before validation again: host job130612271185 and DT job130607022936 hit apt DNS failures resolving azure.archive.ubuntu.com, exit100. Neither is a driver regression or a successful test/schema result.
Appended CI-only9b89ce27, preserving contributor history: host/DT runner mirror lists use Ubuntu's HTTPS archive/security endpoints and apt update fails on repository errors. The two workflows are byte-identical to the validated bootstrap fix prepared for973; YAML/bash syntax checks pass. Test/toolchain/permissions/job-limit and all production driver/DT source remain unchanged. Fresh hosted CI must validate the actual bootstrap and source checks; no blind third retry of the old jobs.
Draft status and the named-cpu legacy Stage2 handoff incompatibility, final-head/module/KUnit/schema and physical link/replug/sleep gates remain unchanged. No Stage1/2 installation or new M3 hardware test was performed.
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
The direct-mirror bootstrap trial now has a result: DT job130632869563 executed the new archive/security list and strict apt update, but both Ubuntu hostnames still failed DNS. It stopped with exit100 before installing tools or running any DT/schema validation. The mirror substitution did not solve the runner issue; this is not a DT failure or a green validation result.
Preserved the full log and shared the result with the lab coordinator. No further unchanged retry or speculative driver/resolver change is being made. Existing exact-ref offline build/check summaries can be reviewed as separate evidence when available; no new hardware/build is requested here. Draft, named-cpu legacy handoff compatibility, actual validation and physical qualification gates remain open.
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
Current host and DT workflows now pass on9b89ce27, including actual DT/schema validation after the earlier dependency-DNS failures. This closes those hosted checks; the prior failed bootstrap attempt is retained history and needs no replay.
Keep draft/unmerged. The installed J613 Stage2 handoff still lacks the named cpu/MxWrap resource, and the driver correctly refuses before mapping/powering it. Green host/DT checks do not qualify that installation or the final link/replug/no-cable/sleep behavior. The modular-build statement and other older trial results retain the exact source/composition limits in the description; no new current-head kernel/KUnit/hardware result is asserted here.
I notified Ryan that the existing Neo/J700 and M4 Pro/J616s shared-regression queue may pass its CI wait, within its previously owner-approved one-shot/default-restoration scope and their own candidate build/admission checks. Those other-generation regressions cannot qualify the new J613 USB4 path. No new M3 test, loader/DT-bundle installation, hardware access or reset/admission bypass was requested.
|
Claude Fable 5.2 on @satchlj's behalf Hardware results for this draft's current head Setup. MacBook Air M3 (J613), kernel Boot. Trial handoff verified; both CIO nodes bound to Both ports passed.
Not run / limits.
|
|
Shared-board regression on J700 (T8140), unattended. This says nothing about J613 function. Trial kernel: integration/aurora 716670b + local merge of 9b89ce2 (merge 839af615), same config as the 716670b baseline. The J700 and J616s DTBs it builds are identical to the baseline's, and the J700 boots its loader-supplied DTB unchanged.
One thing to watch: in one of the two trial runs, DP-1's sysfs EDID read 0 bytes while the output was in DPMS off. The connector stayed connected with its mode and was still connected after both suspend cycles. Neither baseline run showed it, and two runs can't tell a regression from the monitor going to sleep. J700 has no CIO/USB4 domain, so the CIO row only checks that no errors appear. J616s rows are still pending (that Mac is offline). |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
The new current-feature-head J613 report6805776917 closes the two-port link/XDomain/ping, one unplug/replug per port and no-cable observations for its stated combined kernel plus one-shot aura153@182d13e0 trial. Both CIO nodes bound, so the named-CPU/MxWrap handoff was usable in that trial. This supersedes the earlier claim that no current-feature-head J613 link result existed. The installed legacy loader remains unchanged; the trial does not qualify a kernel-only upgrade on its old handoff tree.
Keep draft. J613 suspend was not exercised, and the description’s carried sleep coordination still needs its pre-merge review/qualification or separation. The trial rejected native display handoff and used the boot framebuffer, so it does not establish simultaneous Thunderbolt/native-display operation. The battery-threshold unit’s start-limit failure is unresolved; do not call the entire userspace session clean. No current throughput, Linux-to-Linux, repeated three-cycle/orientation or USB2/3-tour result is claimed.
Ryan’s separate6806457668 J700 comparison closes its stated shared-board display/GPU/USB/DPMS/two-RTC-cycle rows against baseline716670b9 with local merge839af615. It does not test a CIO domain or J613 behavior; the isolated off-state EDID observation is not diagnosed. J616s remains pending/offline.
Current host/DT checks still pass. No source, loader/default, hardware or new M3 test action was performed or requested by this review; the remaining gates have been narrowed to the evidence above.
Merge integration/aurora at 3d015d3, preserving the existing J613 commits and current integration changes. Resolve the sole textual conflict in pmgr-pwrstate.h by keeping both the J613 verify_off helper and main's verify_state helper, including their disabled-config stubs. Retain main's consumer_is_off declaration and stub. The production PMGR witness and T8122 MSI selector host tests pass. Both enabled declarations and disabled-config helper behavior compile; the disabled helpers return EOPNOTSUPP. Python syntax and whitespace checks pass. No full kernel, DT/schema, KUnit or hardware qualification is claimed for this merge. The series remains draft. Assisted-by: LLM Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
left a comment
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
Resolved the integration conflict in normal merge f38fa76 (parents9b89ce27 and3d015d3d; tree637d827d). The sole manual conflict was the disabled-config PMGR header: kept verify_off(), verify_state(), and main’s consumer_is_off() declarations/stubs. The other files merged cleanly; all18 PR-path modes and contributor history are preserved.
Production PMGR witness and T8122 MSI-selector host tests passed, along with enabled-header declaration compilation, disabled-header EOPNOTSUPP checks, Python syntax and whitespace. Header-resolution strict checkpatch0/0/0; aggregated PR delta has0 errors,2 DT patch-organization warnings and1 existing DTS blank-line check. No new full kernel/module-link, DT/schema, KUnit or hardware result is claimed. Fresh host43485979168 and DT43485979243 workflows are running on this head.
The fork update used Git transport with an exact old-head lease after both connector and direct API permissions were refused. Published commit parents/tree/header were read back: old9b89 remains first parent, so history is preserved. Keep draft and remaining compatibility/sleep/functional gates; earlier hardware reports retain their old source/composition scope.
Current maintenance checkpoint (2026-11-13): head
f38fa76afb2fae97bf3675275f7a31367f20cd06, tree637d827d26d924fe07b9cbcf791bd05a1ef1528a. Both current-head hosted checks passed. Still draft; remaining functional qualification is pending.Normal merge of prior head
9b89ce2742e2f43abf70dc9d6331d5211406cc9ewithintegration/aurora@3d015d3d4e7ef8a42fed75842c5a7978819ea39a; contributor commits are retained. The only textual conflict was the disabled-config PMGR header: the resolution keeps both this series'apple_pmgr_ps_verify_off()and main'sapple_pmgr_ps_verify_state(), plus main'sconsumer_is_off()declarations/stubs. Other files merged cleanly.The production PMGR witness and shared T8122 MSI-selector host tests pass. Enabled header declarations compile; disabled-config helpers compile and return
-EOPNOTSUPP. Changed Python syntax and whitespace checks pass. The header-resolution checkpatch reports0 errors/warnings/checks; aggregated PR-delta checkpatch retains two DT patch-organization warnings and one existing DTS blank-line check. Hosted validation on this exact head passed: host run43485979168 completed319/319 registered runs; DT run43485979243 built137 DTBs for both baseline and head (make return0), with0 new warning lines,31 removed (402 baseline versus371 head), and passed its ADT coverage-delta check. This is a successful warning/coverage comparison, not a warning-free tree or a claim that all existing ADT gaps are closed. No full kernel/module link, separate KUnit execution or new hardware run was performed for this merge.Earlier J613 both-port link/ping/replug and J700 regression reports retain their precise old-head/composition scope. The usable one-shot loader trial superseded the earlier lack of named-CPU evidence for that trial; installed legacy-loader/kernel-only compatibility is still distinct. J613 suspend coordination needs review/qualification or separation; simultaneous native display/USB4, repeated orientation/replug and other unqualified rows remain open. No hardware or Stage1/2/default change was requested by this branch maintenance.
Retained original series description and earlier validation history (prior to this maintenance merge)
GPT-6.1 Sol on @satchlj's behalf
Enable the J613 (M3 MacBook Air, T8122) host-to-host USB4 path: T6030-generation MxWrap RUN/pre-RTKit LSTX policy, strict firmware-ready admission, explicit power ownership and witnessed four-domain off boundary, PD/NHI/PHY shutdown coordination, and saved-ADT PCIe-C resources with disjoint MSI slices. Failed power-off quarantines restart. Seven logical commits add the binding description, provider witness, MSI validation, router/session policy, DT resources and production-function host regression. A final commit shares named ECAM/MSI constants and the aperture selector with negative host tests.
Draft: final-head build/KUnit and clean schema validation remain incomplete. This series publishes the pieces exercised in today's trial for review now. It is rebased directly onto current
integration/auroradc8f6f7, not a personal stack. Today's running kernel was the retained Trial 2 source, not this exact rebased head. Additional restrictions scope match data/session coordination and dynamic tunnel containers to J613; these restrictions themselves have not been booted. Sleep coordination carried from the trial remains unqualified and must be reviewed or split before merge; it is not a suspend-support claim.Dependencies and attribution:
No sleep testing, including sleep with a link. Storage/dock/DP tunnels, the USB2/USB3 tour, three-cycle repeated replug and orientation flip were not tested. DP tunnels remain disabled on J613. A separate left-back DP alt-mode Dell test reached 3840x2160@60; this is not a DP tunnel test. Throughput is below macOS and under investigation; no tuning or parity claim.
Scope and no-cable behavior:
The T8122 match selects this policy only on
apple,j613; other T8122 boards keep their old fallback policy. The new root tunnel containers and aliases are included only by J613 and are populated dynamically after cable-triggered router start, not as ordinary/socdevices. No powered-off wrapper reads are added at probe. Other boards retain their old shutdown/PM behavior; the provider helper has no autonomous consumer. The no-cable gate passed in the hardware trial, not yet on this rebase. Deleting J613's disabled unused OTG node prevents older loader pruning from disabling its active ATC0 PHY/DARTs.Validation and outstanding merge gates:
--ignore FILE_PATH_CHANGES(0 errors/0 warnings); range diff whitespace check passes.KeyError: 'uint8-array'onapple,tunable, reproducing the retained kit limitation. This used the retained processed integration schemas; only the ACIO description text changes here. This is not a cleandtbs_checkpass. Binding gaps and the decoder exception remain to close on fresh final-head schemas.Provenance: register windows, IRQs, MSI window and tuning tuples came from the saved J613 ADT, rechecked against current firmware ADT in today's trial. RUN/pre-RTKit LSTX was inferred from the matching T6030 generation/layout, not learned from a J613 macOS ACIO restart trace. Hardware firmware-ready/link and real domain-off witnesses support that candidate, but do not establish Apple's restart/SRAM protocol. No guessed M5 SRAM writes, secure-monitor handoff, copied Apple source, firmware or private trace dumps are included.
Excluded: untested no-RUN parameter and verbose trial-only register diagnostics, RTC/ALS/CPU/SoC sleep and unrelated display changes, DP tunnel enablement, throughput tuning. Human DCO identity is Satya Benson;
Assisted-by: LLMfollowsDocumentation/process/coding-assistants.rst, as in #1486 . Prepared with Codex (GPT-6.1 Sol) from the retained local J613 implementation.Modular production build and legacy-tree qualification
The modular J613 config (
USB4=m,USB4_APPLE_SOC=m) exposed an undefinedtb_apple_sleep_quiesceat modpost. The published GPL export fixes that linkage;strict checkpatch and the full LLVM18 Image/modules/DTBs build pass.
The all-live-head 30.11 exact-binary J613 trial passed rendering, camera, no-finger
SEP start/stop, memory-floor and all-core IPC checks. It is not promoted:
both CIO probes fail because the installed Stage 2 handoff DT has only
rc,sramresources, whereas this driver requires the named
cpuMxWrap resource. Theprobe returns EINVAL before mapping or powering it. Current Linux DTS has the
resource, but a kernel DTB install does not replace the Stage 2 handoff tree.
30.9 remains the working default; no Stage 1/2 write was made. A legacy-tree
adapter or a later attended DT-bundle update needs separate review before
shipping this live head to that installation.