Repository navigation
scripts/dtc: let the ADT coverage ratchet introduce a new board - #1215
Merged
Merged
Conversation
A board added together with its inventory had no base DTB, so the bootstrap measured the head inventory against a file that did not exist. The coverage step then failed with ENOENT. The aurora-wip sync #1210 hit this for t6050-j716s and t6050-j873s, because aurora-wip had no T6050 trees yet. Nothing at the base can regress for such a board, so only check that its own inventory resolves in the head DTB. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
RyanTheTide
added a commit
that referenced
this pull request
Nov 8, 2026
Brings #1215, the ADT coverage fix for boards that are new to the base. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/dtc/apple-adt-coverage.pybootstraps the baseline for a board whose inventory is new by measuring the head inventory against the base DTB. If the board itself is new, that base DTB doesn't exist, and dt-checks fails with ENOENT. The aurora-wip sync #1210 hit this fort6050-j716sandt6050-j873s, because aurora-wip has no T6050 trees yet.With this change, a board that has no base DTB counts as new: nothing at the base can regress, but every path in its inventory must still resolve in the head DTB. A new test covers both outcomes, and it fails without the fix.
Test:
python3 scripts/dtc/apple-adt-coverage-test.py, 19 tests OK (18 before plus the new one).🤖 Generated with Claude Code