Repository navigation
Conversation
Share explicit group resolution across build, watch and list; isolate outputs and dependency metadata, track membership changes and coordinate shutdown. Remove false shell-success for failed CLI commands. Stop silently ignoring unreadable existing watch directories and report their filesystem errors. Keep the executing Console installation authoritative over older workspace copies.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ad3c32888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Register the authoritative Console namespace in the shared extension loader after workspace autoload registration and before manifest parsing. Prevent older workspace Console classes from shadowing the executing CLI during discovery and later commands. Extend the real-entrypoint regression with an installed extension manifest and incompatible older extension class. Verified the regression fails before this correction; affected discovery tests and level-8 analysis pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone
Console component-group support after 0.10.5. Andrew owns the release version and release.
Type
feature, bug, test, docs
Why this belongs in this milestone
Applications need independent site and editor bundles so a site-only change does not rebuild unrelated editor/runtime assets.
What changed
--groupselection to build, watch and list through one resolver. Preserve ungrouped discovery and output paths.What did not change
No Core/request-time code, dependencies, compiler/runtime builds, deployment uploads, tags or releases changed.
Verification
Measured PHP orchestration used a 102-component fixture and fake esbuild. After interval-based polling, discovery medians were 2.344/2.353 ms, peak allocation 89,064/95,664 bytes, and one short watch CPU observation was 17.137/15.696 ms. The original watch sample was 5.018/8.380 ms before the polling correction. These observations are noisy, exclude native compilation and do not certify zero overhead. Later small correctness fixes were not re-benchmarked. Default topology detection is approximately one second plus scheduling/build/browser latency.
User impact
Grouped bundles can be built independently. Empty watch sessions remain active for the first component. Failed commands now return nonzero status. Unreadable existing source directories raise an error.
Release notes
Needed: component groups, watch behavior and corrected command failures. Andrew handles the release.
Upgrade notes
Existing configuration needs no migration. Groups are opt-in; shell workflows relying on false success must handle command failures.