Skip to content

fix: the length of an empty array is zero #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 1 commit into from
Aug 21, 2026
+4 −2
Merged

fix: the length of an empty array is zero #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/expr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,9 +1293,11 @@ defmodule AshSql.Expr do
%Fragment{
embedded?: pred_embedded?,
arguments: [
raw: "array_length((",
raw: "coalesce(array_length((",

@zachdaniel zachdaniel Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering the list twice is not great 😓 Is there really no other way to go about this?

@zachdaniel zachdaniel Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it's fine. If its a literal list then the value would be expanded by our expression builder at runtime.

expr: list,
raw: "), 1)"
raw: "), 1), cardinality((",
expr: list,
raw: ")))"
]
},
bindings,
Expand Down
Loading