fix: the length of an empty array is zero - #255
Merged
zachdaniel merged 1 commit intoAug 21, 2026
Conversation
Merged
7 tasks
zachdaniel
reviewed
Aug 21, 2026
| embedded?: pred_embedded?, | ||
| arguments: [ | ||
| raw: "array_length((", | ||
| raw: "coalesce(array_length((", |
Contributor
There was a problem hiding this comment.
Rendering the list twice is not great 😓 Is there really no other way to go about this?
Contributor
There was a problem hiding this comment.
Actually, I think it's fine. If its a literal list then the value would be expanded by our expression builder at runtime.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes ash-project/ash_postgres#834
The list is rendered twice, since
cardinalityalone regresses nested arrays, by counting across all dimensions. Similarlycoalesce(.., 0)turns anilarray into0.Tests will be in an ash_postgres PR, which will require ash_sql to release to go green.