Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/reatom-idiomatic-resize-observer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-karkas": patch
---

Make `withResizeObserver` idiomatic Reatom: expose plain `Size` state (`{ width, height }`) instead of the live `ResizeObserverEntry` platform object, keep state serializable, and rename the derived atom from `sizeEntry` to `size`.
26 changes: 18 additions & 8 deletions apps/demo/src/shared/reatom/resize-observer.ts
Original file line number Diff line number Diff line change
@@ -1,27 +1,37 @@
import { computed, memo, reatomObservable, wrap, type Atom } from '@reatom/core'

export type Size = { width: number; height: number }

export const withResizeObserver = () => {
return (target: Atom<HTMLElement | null>) => {
const sizeEntry = computed(() => {
const stateAtom = memo(() => {
const size = computed<Size | null>(() => {
const sizeAtom = memo(() => {
const node = target()
if (!node) return null

return reatomObservable<ResizeObserverEntry | undefined>({
initState: undefined,
return reatomObservable<Size>({
initState: null,
subscribe: (set) => {
const observer = new ResizeObserver(
wrap((entries) => set(entries.find((entry) => entry.target === node))),
wrap((entries) => {
const entry = entries.at(-1)
if (entry) {
set({
width: entry.contentRect.width,
height: entry.contentRect.height,
})
}
}),
)
observer.observe(node)
return () => observer.disconnect()
},
})
})

return stateAtom?.()
}, `${target.name}.sizeEntry`)
return sizeAtom()
}, `${target.name}.size`)

return { sizeEntry }
return { size }
}
}
2 changes: 1 addition & 1 deletion apps/demo/src/widgets/app-shell/ui/AppShell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const desktopSidebarCollapsedAtom = reatomBoolean(false, 'desktopSidebar.collaps
const measureRefAtom = atom<HTMLElement | null>(null, 'appShell.measureRef').extend(
withResizeObserver(),
(target) => ({
height: computed(() => target.sizeEntry()?.contentRect.height ?? 0, 'appShell.headerHeight'),
height: computed(() => target.size()?.height ?? 0, 'appShell.headerHeight'),
}),
)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,37 @@
import { computed, memo, reatomObservable, wrap, type Atom } from '@reatom/core'

export type Size = { width: number; height: number }

export const withResizeObserver = () => {
return (target: Atom<HTMLElement | null>) => {
const sizeEntry = computed(() => {
const stateAtom = memo(() => {
const size = computed<Size | null>(() => {
const sizeAtom = memo(() => {
const node = target()
if (!node) return null

return reatomObservable<ResizeObserverEntry | undefined>({
initState: undefined,
return reatomObservable<Size>({
initState: null,
subscribe: (set) => {
const observer = new ResizeObserver(
wrap((entries) => set(entries.find((entry) => entry.target === node))),
wrap((entries) => {
const entry = entries.at(-1)
if (entry) {
set({
width: entry.contentRect.width,
height: entry.contentRect.height,
})
}
}),
)
observer.observe(node)
return () => observer.disconnect()
},
})
})

return stateAtom?.()
}, `${target.name}.sizeEntry`)
return sizeAtom()
}, `${target.name}.size`)

return { sizeEntry }
return { size }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const desktopSidebarCollapsedAtom = reatomBoolean(false, 'desktopSidebar.collaps
const measureRefAtom = atom<HTMLElement | null>(null, 'appShell.measureRef').extend(
withResizeObserver(),
(target) => ({
height: computed(() => target.sizeEntry()?.contentRect.height ?? 0, 'appShell.headerHeight'),
height: computed(() => target.size()?.height ?? 0, 'appShell.headerHeight'),
}),
)

Expand Down
Loading