Repository navigation
refactor(reatom): idiomatic withResizeObserver exposing plain Size state - #52
Open
vekilibot[bot] wants to merge 1 commit into
Open
vekilibot[bot] wants to merge 1 commit into
vekilibot[bot] wants to merge 1 commit into
Conversation
Expose { width, height } plain data instead of the live ResizeObserverEntry
platform object, so state stays serializable and consumers read a stable
shape. Rename the derived atom sizeEntry -> size and simplify the entry
lookup (single observed node). Update the demo app-shell and the
create-karkas template copy, plus a patch changeset.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withResizeObservernow exposes plainSizestate ({ width, height }) instead of the liveResizeObserverEntryplatform object — Reatom state should be immutable, serializable plain datasizeEntry→size(domain data, not the platform type) and simplified the entry lookup toentries.at(-1)since a single node is observedtarget()read insidememo— it's load-bearing: memo recreates the observable (and disconnects the old ResizeObserver) when the node changesAppShell(target.size()?.height ?? 0), the mirroredcreate-karkastemplate copy, and added a patch changesetTest plan
mise run ci(or repo equivalent) on the branchappShell.headerHeightstill tracks it