Skip to content

ci(bench): remove the walltime job - #132

Merged
lukecotter merged 1 commit into
mainfrom
ci/remove-walltime
Oct 11, 2026
Merged

lukecotter merged 1 commit into
mainfrom
ci/remove-walltime

Conversation

@lcottercertinia

Copy link
Copy Markdown
Collaborator

📝 Overview

The walltime job runs on a CodSpeed macro runner, and the org does not allow those runners on public repositories. A dispatch of the Benchmarks workflow queues the job and it never starts. The queued job, and CodSpeed's CodSpeed Macro Runners check (action_required), then attach to the dispatched commit and leave its pull request unmergeable, as run #85 did to #128. Enabling it would mean an org-level runner setting for one repository, so the job goes.

🛠️ Changes

  • benchmark.yml: remove the walltime job. workflow_dispatch stays, so the simulation run can still be started by hand.
  • .github/workflows/README.md: drop walltime from the trigger table and the description; one "No walltime job" row replaces the two walltime rows, and points to pnpm run bench:large for wall time.
  • AGENTS.md, benchmarks/AGENTS.md: drop the sentence about the manual walltime job.

🧩 Type of change

  • 🐛 Bug fix — fixes an issue
  • ✨ Feature — adds new functionality
  • ♻️ Refactor — no behaviour change
  • ⚡ Performance
  • 📝 Docs
  • 🔧 Chore — tooling, CI, deps
  • 💥 Breaking change

🔗 Related issues

None filed. Unblocks #128, whose head carried the queued dispatch (since cancelled).

✅ Checklist

  • Tests added/updated — CI config and docs only; nothing to test.
  • pnpm run ci passes locally — biome and both typechecks pass; 4 tests in src/next/__tests__/Worker.test.ts fail in my environment (Node 22.22, the worker cannot import api/hosts.js from .ts source). They fail identically on main without this change.
  • Changeset added (pnpm changeset) if this affects the published package — does not apply; nothing published changes.
  • Docs updated if behaviour or the public API changed

🤖 Generated with Claude Code

https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe


Generated by Claude Code

The job needs a CodSpeed macro runner, which the org does not allow for
public repositories, so a dispatch queues it and never starts it. The
queued job and CodSpeed's action_required check then hold the commit's
pull request unmergeable. pnpm run bench:large measures wall time locally.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe
@codspeed

codspeed Bot commented Oct 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 3 untouched benchmarks


Comparing ci/remove-walltime (09ad930) with main (0785c68)

Open in CodSpeed

@lcottercertinia lcottercertinia mentioned this pull request Oct 11, 2026
3 of 11 tasks
@lukecotter
lukecotter merged commit f0bca45 into main Oct 11, 2026
9 checks passed
@lukecotter
lukecotter deleted the ci/remove-walltime branch October 11, 2026 08:43
lukecotter added a commit that referenced this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants