Repository navigation
ci(bench): remove the walltime job - #132
Merged
Merged
Conversation
The job needs a CodSpeed macro runner, which the org does not allow for public repositories, so a dispatch queues it and never starts it. The queued job and CodSpeed's action_required check then hold the commit's pull request unmergeable. pnpm run bench:large measures wall time locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe
3 of 11 tasks
lukecotter
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Overview
The
walltimejob runs on a CodSpeed macro runner, and the org does not allow those runners on public repositories. A dispatch of the Benchmarks workflow queues the job and it never starts. The queued job, and CodSpeed'sCodSpeed Macro Runnerscheck (action_required), then attach to the dispatched commit and leave its pull request unmergeable, as run #85 did to #128. Enabling it would mean an org-level runner setting for one repository, so the job goes.🛠️ Changes
benchmark.yml: remove thewalltimejob.workflow_dispatchstays, so the simulation run can still be started by hand..github/workflows/README.md: drop walltime from the trigger table and the description; one "No walltime job" row replaces the two walltime rows, and points topnpm run bench:largefor wall time.AGENTS.md,benchmarks/AGENTS.md: drop the sentence about the manualwalltimejob.🧩 Type of change
🔗 Related issues
None filed. Unblocks #128, whose head carried the queued dispatch (since cancelled).
✅ Checklist
pnpm run cipasses locally — biome and both typechecks pass; 4 tests insrc/next/__tests__/Worker.test.tsfail in my environment (Node 22.22, the worker cannot importapi/hosts.jsfrom.tssource). They fail identically onmainwithout this change.pnpm changeset) if this affects the published package — does not apply; nothing published changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe
Generated by Claude Code