Repository navigation
ci(bench): remove the walltime job - #133
Merged
Merged
Conversation
The job needs a CodSpeed macro runner, which the org does not allow for public repositories, so a dispatch queues it and never starts it. The queued job and CodSpeed's action_required check then hold the commit's pull request unmergeable. pnpm run bench:large measures wall time locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe
lukecotter
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Overview
#132 for
feat/v1. A dispatch runs the workflow file on the branch it is started from, so untilmainis merged in, a dispatch onfeat/v1or a branch stacked on it still queueswalltimeon a macro runner the org does not allow. That queued job left #128 and #129 unmergeable (runs #85 and #84, since cancelled). With this, a dispatch on these branches runs the simulation and memory benchmarks only.🛠️ Changes
benchmark.yml: remove thewalltimejob.workflow_dispatchstays..github/workflows/README.md: drop walltime from the trigger table and the description, keeping this branch's memory-mode text; one "No walltime job" row replaces the two walltime rows.AGENTS.md,benchmarks/AGENTS.md: drop the sentence about the manualwalltimejob.The same commit as #132, cherry-picked; the docs conflicts were resolved by hand against this branch's memory-mode wording. When
mainis next merged in, the two should resolve to this text.🧩 Type of change
🔗 Related issues
Same change as #132, for
feat/v1. Unblocks benchmark dispatches on #128 and #129.✅ Checklist
pnpm run cipasses locally — not rerun on this branch; the diff is YAML and Markdown only, which no check inpnpm run cireads. Onmainthe same change passed biome and both typechecks.pnpm changeset) if this affects the published package — does not apply; nothing published changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01QDthfCKoDiYWqy5FwMeJPe
Generated by Claude Code