Repository navigation
feat(setup): ship the framework's agent settings as a template - #1671
Merged
Merged
Conversation
potiuk
force-pushed
the
feat/claude-settings-template
branch
2 times, most recently
from
October 16, 2026 09:27
e62c3e6 to
1e1093a
Compare
The repository committed its own .claude/settings.json, so every contributor's agent silently inherited the maintainers' sandbox, permission and self-adoption choices, any change to them was a repository change, and a checkout could not differ from the baseline without a dirty tree. The file now ships, unchanged, as tools/agent-isolation/claude-settings.template.json, and .claude/settings.json is gitignored: - sandbox-lint lints the template by default; the workflow, its job name and the .asf.yaml note follow, so the baseline stays linted in CI. - The pre-flight fingerprint covers the template through tools/agent-isolation/ (constant regenerated). - CONTRIBUTING gains "Agent settings" (copy or merge the template; personal additions in settings.local.json); setup-isolated-setup-install gains Step T for a framework checkout; setup-isolated-setup-verify check 1 reports a missing copy. - Links and prose that meant this repository's file point at the template (threat model M.14/M.29, secure-agent docs, the write-skill checklist, specs). An adopter's committed .claude/settings.json floor is unchanged. Closes apache#1639. Generated-by: Claude Opus 5
potiuk
force-pushed
the
feat/claude-settings-template
branch
from
October 16, 2026 09:41
1e1093a to
a915505
Compare
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/settings.json, so every contributor's agent silently inherited the maintainers' sandbox, permission and self-adoption choices; each change to them was a repository change, and a checkout could never differ from the baseline without a dirty tree.tools/agent-isolation/claude-settings.template.json, and.claude/settings.jsonis gitignored. Every surface that referenced the committed file is retargeted:sandbox-lintlints the template by default; the workflow paths, its job name and the.asf.yamlnote follow, so the baseline stays linted in CI.tools/agent-isolation/(the separate entry is gone; constant regenerated)..claude/settings.jsonin.pre-commit-config.yamlis dropped — the file is no longer tracked.sandbox-lintREADME, and three specs.settings.local.json);setup-isolated-setup-installgains Step T for a framework checkout;setup-isolated-setup-verifycheck 1 reports a missing copy (✗) or a missing block (⚠).Out of scope, as the issue says: the baseline's contents (unchanged), and an adopter's committed
.claude/settings.jsonfloor written byadopt.Closes #1639.
Type of change
setup-isolated-setup-install,setup-isolated-setup-verify)tools/sandbox-lintdefault path and test;setup-preflightfingerprint sources)sandbox-lintworkflow,.asf.yaml,.pre-commit-config.yaml,.gitignore)Test plan
prek run --all-filespassesuv run sandbox-lint—OK (tools/agent-isolation/claude-settings.template.json matches tools/sandbox-lint/expected.json)tools/sandbox-linttests (270 passed, incl. the doc / allowed-domains consistency test now reading the template)tools/setup-preflighttests (252 passed); fingerprint constant regeneratedsetup-isolated-setup-install/-verify— not run (prose additions only)Notes for reviewers
.claude/settings.jsonon disk (it becomes untracked and ignored); a fresh clone has none untilcp tools/agent-isolation/claude-settings.template.json .claude/settings.json.setup-isolated-setup-verifyflags it.tools/sandbox-lint/expected.json.Gen-AI disclosure: prepared with the assistance of Claude Code (Claude Opus 5); reviewed by the author.
🤖 Generated with Claude Code