Repository navigation
fix(ci): refuse a committed .claude/settings.json in sandbox-lint - #1675
Merged
Merged
Conversation
Since apache#1639 the repository's agent settings ship as a template and .claude/settings.json is gitignored, so sandbox-lint stopped watching that path. A PR could still force-add it, and Claude Code would load the committed copy for everyone who checks the repository out, without CI ever linting it. The workflow runs again when .claude/settings.json changes, and a new step fails while the file is tracked, pointing the author at the template and the baseline instead. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/agent-isolation/claude-settings.template.jsonand.claude/settings.jsonis gitignored, so thesandbox-lintworkflow stopped watching that path. A PR can still force-add the file; Claude Code would then load the committed copy for everyone who checks the repository out, and CI would never lint it, so it could weaken the sandbox around the linted template..claude/settings.jsonis back in the workflow'spull_requestandpushpath filters.git rm --cached..asf.yamlnote on why the job is not a required check lists the path.Type of change
sandbox-lintworkflow,.asf.yamlcomment)Test plan
prek run --all-filespassesNotes for reviewers
.asf.yamlexplains why that cannot be required.Gen-AI disclosure: prepared with the assistance of Claude Code (Claude Opus 5); reviewed by the author.
🤖 Generated with Claude Code