Repository navigation
[To dev/1.3] Fix Load task cleanup and input handling - #18936
Merged
jt2594838 merged 1 commit intoOct 20, 2026
Merged
Conversation
Port the improvements from PR apache#18772 to the legacy Load implementation. Adapt the active loader tests and cover rollback while nested Load work remains active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On
dev/1.3, rollback can close a Load task's writers while its RPC work is still running. Track active work, including nested slice assembly and writing, so rollback rejects further work while cleanup is pending and releases resources after the last active call finishes.This also preserves the other improvements from #18772:
The cleanup changes target the legacy global Load manager on
dev/1.3. #18698 replaced that lifecycle onmasterwith per-DataRegion consensus commands and consensus-aware staging retention, so #18772 is being replaced by this PR for the legacy implementation. Adapt the scanner regression test to thedev/1.3loader API and cover rollback while nested work remains active.Validation
mvn -o -pl iotdb-core/datanode spotless:applymvn -o -pl iotdb-core/datanode -am "-Dtest=LoadTsFilePieceNodeAssemblerTest,ActiveLoadDirScannerTest,LoadTsFileManagerTest" "-Dsurefire.failIfNoSpecifiedTests=false" test— 13 tests passed, no failures or errors.mvn -o test-compile -DskipTests— full reactor passed (44 modules).mvn -o test-compile -P with-zh-locale -DskipTests— full reactor passed (44 modules).Self-reviewed concurrent task admission, rollback and cleanup.
Added or adapted regression tests for all three changes.