Repository navigation
Conversation
2 tasks done
Collaborator
Author
|
Closing in favor of #18936, which preserves all three improvements on dev/1.3. #18698 replaced the global Load manager and EXECUTE/ROLLBACK lifecycle on master with per-DataRegion consensus commands and consensus-aware staged-file retention, so the cleanup/rollback implementation in this PR no longer fits the master Load path. The buffer-allocation and failure-directory scanning improvements remain independently applicable to master, but the legacy cleanup changes should not be restored there just to resolve these conflicts. |
jt2594838
pushed a commit
that referenced
this pull request
Oct 20, 2026
Port the improvements from PR #18772 to the legacy Load implementation. Adapt the active loader tests and cover rollback while nested Load work remains active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
mvn spotless:apply -pl iotdb-core/datanodemvn -pl iotdb-core/datanode "-Dtest=LoadTsFilePieceNodeAssemblerTest,ActiveLoadDirScannerTest,LoadTsFileManagerTest" test(13 tests passed)