Skip to content

[Test] Fix relational session cleanup and invalid timestamp test setup #18887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
Oct 16, 2026
Merged

[Test] Fix relational session cleanup and invalid timestamp test setup #18887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59566ca
[Test] Retry session database cleanup after asynchronous table deletion
Caideyipi Oct 15, 2026
acaf306
[Test] Add a field to invalid timestamp insert test
Caideyipi Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions ...n-test/src/test/java/org/apache/iotdb/relational/it/session/IoTDBSessionRelationalIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.apache.iotdb.itbase.category.TableLocalStandaloneIT;
import org.apache.iotdb.rpc.IoTDBConnectionException;
import org.apache.iotdb.rpc.StatementExecutionException;
import org.apache.iotdb.rpc.TSStatusCode;
import org.apache.iotdb.session.TableSessionBuilder;

import org.apache.tsfile.enums.ColumnCategory;
Expand Down Expand Up @@ -98,9 +99,19 @@ public void setUp() throws Exception {
@After
public void tearDown() throws Exception {
try (ITableSession session = EnvFactory.getEnv().getTableSessionConnection()) {
session.executeNonQueryStatement("DROP DATABASE IF EXISTS db1");
session.executeNonQueryStatement("DROP DATABASE IF EXISTS db2");
session.executeNonQueryStatement("DROP DATABASE IF EXISTS db3");
for (String database : Arrays.asList("db1", "db2", "db3")) {
// Asynchronous DROP TABLE procedures may still be running when the test finishes.
Awaitility.await()
.atMost(60, TimeUnit.SECONDS)
.pollInSameThread()
.ignoreExceptionsMatching(
e ->
e instanceof StatementExecutionException
&& ((StatementExecutionException) e).getStatusCode()
== TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode())
.untilAsserted(
() -> session.executeNonQueryStatement("DROP DATABASE IF EXISTS " + database));
}
}
}

Expand Down Expand Up @@ -259,30 +270,31 @@ public void insertWrongTimeSqlTest()
throws IoTDBConnectionException, StatementExecutionException {
try (ITableSession session = EnvFactory.getEnv().getTableSessionConnection()) {
session.executeNonQueryStatement("USE \"db1\"");
// Include a FIELD column so schema validation does not mask invalid timestamps.
session.executeNonQueryStatement(
"create table wrong_time(color string tag, device_id string tag,city string attribute)");
"create table wrong_time(color string tag, device_id string tag,city string attribute, value int32 field)");
try {
session.executeNonQueryStatement("insert into wrong_time values('aa','bb','cc','dd')");
session.executeNonQueryStatement("insert into wrong_time values('aa','bb','cc','dd',1)");
fail("No exception thrown");
} catch (StatementExecutionException e) {
assertEquals(
"701: Input time format aa error. Input like yyyy-MM-dd HH:mm:ss, yyyy-MM-ddTHH:mm:ss or refer to user document for more info.",
e.getMessage());
}
try {
session.executeNonQueryStatement("insert into wrong_time values(1+1,'bb','cc','dd')");
session.executeNonQueryStatement("insert into wrong_time values(1+1,'bb','cc','dd',1)");
fail("No exception thrown");
} catch (StatementExecutionException e) {
assertEquals("701: Unsupported expression: (1 + 1)", e.getMessage());
}
try {
session.executeNonQueryStatement("insert into wrong_time values(1.0,'bb','cc','dd')");
session.executeNonQueryStatement("insert into wrong_time values(1.0,'bb','cc','dd',1)");
fail("No exception thrown");
} catch (StatementExecutionException e) {
assertEquals("701: Unsupported expression: 1E0", e.getMessage());
}
try {
session.executeNonQueryStatement("insert into wrong_time values(true,'bb','cc','dd')");
session.executeNonQueryStatement("insert into wrong_time values(true,'bb','cc','dd',1)");
fail("No exception thrown");
} catch (StatementExecutionException e) {
assertEquals("701: Unsupported expression: true", e.getMessage());
Expand Down
Loading