Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IoTDBSessionRelationalIT.tearDown()can fail with status 304 when an asynchronousDROP TABLEprocedure is still finishing as cleanup drops its database. For example,insertAllNullSqlTestdropsdb1.all_nullimmediately before database cleanup.Retry each database drop for up to 60 seconds when the server returns
OVERLAP_WITH_EXISTING_TASK, using the existing table session and Awaitility on the same thread. Other statement errors and connection errors propagate immediately.insertWrongTimeSqlTestalso used a table containing only TAG and ATTRIBUTE columns. Add a FIELD column and a valid field value to each insert so the test isolates timestamp validation. Keep the existing 701 assertions for invalid date strings, arithmetic expressions, floating-point values, and boolean values.Validation
Integration-test compilation, Checkstyle, and Spotless passed.
DataNode compilation and packaging passed.
Focused
TableSimpleITrun covering invalid timestamps, missing FIELD columns, and cleanup after table deletion: 6 tests passed; Failsafe verification passed.Local fault injection against the actual
tearDown()method: normal cleanup and repeated 304 responses on all three databases completed successfully; unexpected statement errors and connection errors propagated immediately, with the session closed in every case.Full
IoTDBSessionRelationalITrun onTableSimpleIT, using the DataNode rebuilt from this checkout: 29 tests passed, 0 failures, 0 errors, 0 skipped, with no cleanup errors; Failsafe verification passed.Self-reviewed.
Tested in a 1 ConfigNode / 1 DataNode cluster.