Repository navigation
perf(table): decode v2 snapshot history directly - #2642
Open
iceberg-kitten wants to merge 3 commits into
Open
iceberg-kitten wants to merge 3 commits into
iceberg-kitten wants to merge 3 commits into
Conversation
Call the version-specific decoder after preflight and preserve type error offsets with and without partition spec normalization. Signed-off-by: Minh Vu <356647812+iceberg-kitten@users.noreply.github.com>
Share wire decoding and validation with the standard path. Decode common snapshots directly, fall back per entry, and allocate history capacity on demand. Signed-off-by: Minh Vu <356647812+iceberg-kitten@users.noreply.github.com>
iceberg-kitten
force-pushed
the
perf/metadata-decode-v2-snapshots
branch
from
November 18, 2026 23:49
dbfd60e to
f1f5572
Compare
…e-v2-snapshots # Conflicts: # table/metadata_preflight_test.go
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decode ordinary snapshot fields and summaries directly during eager v2 metadata reads. Both paths share the v2 wire decoder and metadata validation. Unusual snapshots fall back to
encoding/jsonindividually. The fast path respects the full document’s nesting limit, copies strings retained by each snapshot, and allocates only what empty and single-entry histories need.Builds on #2641. Snapshot-only diff.
Benchmark
In-memory v2 metadata parsing across four table shapes. Values are #2641 (
301247d) → this PR. The 64-snapshot case has populated summaries.12 fresh processes per revision on one pinned core (Intel i9-12900HK, Linux amd64, Go 1.26.3,
GOMAXPROCS=1,GOGC=100). Revision order rotated between rounds. Values are medians from benchstat, with 95% confidence intervals for timing. Timing changes usep < 0.005.The 10-snapshot fixture is below the 4 KiB cutoff for eager decoding.
Run once per revision in each round and save each revision’s output separately.
Validation
make testpassed on this branch. Lint passed on the metadata stack.