Repository navigation
perf(table): decode v2 history logs directly - #2643
Open
iceberg-kitten wants to merge 5 commits into
Open
iceberg-kitten wants to merge 5 commits into
iceberg-kitten wants to merge 5 commits into
Conversation
Call the version-specific decoder after preflight and preserve type error offsets with and without partition spec normalization. Signed-off-by: Minh Vu <356647812+iceberg-kitten@users.noreply.github.com>
Share wire decoding and validation with the standard path. Decode common snapshots directly, fall back per entry, and allocate history capacity on demand. Signed-off-by: Minh Vu <356647812+iceberg-kitten@users.noreply.github.com>
Decode common log records directly and fall back for unusual records. Preserve null and empty logs, and defer errors to the standard metadata parser. Signed-off-by: Minh Vu <356647812+iceberg-kitten@users.noreply.github.com>
iceberg-kitten
force-pushed
the
perf/metadata-decode-v2-history-logs
branch
from
November 18, 2026 23:49
ff714a3 to
4e9c8b4
Compare
added 2 commits
November 19, 2026 14:30
…e-v2-snapshots # Conflicts: # table/metadata_preflight_test.go
…ecode-v2-history-logs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decode ordinary
snapshot-logandmetadata-logentries directly during eager v2 reads. Unusual records can still useencoding/jsonindividually. If a log fails to decode, let the standard metadata parser report the error. Each decoded metadata-log entry owns its filename.Builds on #2641 and #2642. History-log-only diff.
Benchmark
In-memory v2 metadata parsing across four table shapes. Values are #2642 (
f1f5572) → this PR. The 64-snapshot case has populated summaries.12 fresh processes per revision on one pinned core (Intel i9-12900HK, Linux amd64, Go 1.26.3,
GOMAXPROCS=1,GOGC=100). Revision order rotated between rounds. Values are medians from benchstat, with 95% confidence intervals for timing. Timing changes usep < 0.005.The 10-snapshot fixture is below the 4 KiB cutoff for eager decoding.
Run once per revision in each round and save each revision’s output separately.
Earlier warm file-load measurements
The initial stack was also measured on a warm 66,321-byte v2 metadata file. Median load time fell from 16.748 ms on
mainto 13.951 ms with #2641, 4.624 ms through #2642, and 1.989 ms through #2643. These were three matched rounds at roughly 0.9 GHz with Go 1.26.10 andGOGC=100.A separate single-round comparison at roughly 2.9 GHz measured 0.185 ms for Java 1.12.0, 0.339 ms for the initial Go stack, 0.420 ms for Rust (
641f59049e0a), and 3.287 ms for Gomain(e7a4d96). Each result is the median of four timing windows.Validation
make testpassed on this branch. Lint passed on the metadata stack.