Repository navigation
ci: set timeout-minutes on every workflow job - #7679
Merged
Merged
Conversation
Without timeout-minutes a job runs for GitHub's six hour default. A hung suite then holds a runner, and its pipeline, for six hours before it reports. Set a limit on every job that runs on a runner, at about two to three times its slowest recent successful run, and document how the limits were chosen in the workflows README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
comphead
approved these changes
Nov 18, 2026
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @andygrove I was actually thinking about the same last week
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
bvolpato
pushed a commit
to bvolpato/datafusion
that referenced
this pull request
Nov 19, 2026
## Which issue does this PR close? Related to apache#25148. This follows apache/datafusion-comet#7679. ## Rationale for this change GitHub Actions defaults to six hours per job. Explicit job timeouts let CI report a hung job sooner and free its runner. ## What changes are included in this PR? - Add timeouts to the 49 runner jobs that lacked one, so all 52 runner jobs have an explicit limit. - Use recent successful Runs-On and GitHub-hosted jobs, including fork runs, to size the limits. The Linux test took up to about 10 minutes upstream and 25 minutes on a fork in the sample. Its 90-minute limit leaves room for cold caches. [Upstream run](https://github.com/apache/datafusion/actions/runs/44273230362/job/134695832557), [fork run](https://github.com/kumarUjjawal/datafusion/actions/runs/42294482708/job/128158781944). - Use the existing 15-minute `ubuntu-slim` runner limit for the docs jobs, Verify Vendored Code, and Detect Unused Dependencies. - Document how to choose and adjust job timeouts in the contributor guide. ## What is the testing strategy for this PR? Parsed all 20 workflows and verified every runner job has a timeout. Compared the parsed YAML against `main` to confirm the timeout additions are the only workflow changes. The existing CI-script tests, required-check mapping, and Prettier checks passed. ## Are there any user-facing changes? CI jobs now stop when they reach their configured timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
There is no issue. This came up while investigating CI failures on the branch-1.2 backports.
Rationale for this change
No test or build job in our workflows sets
timeout-minutes, so each one gets GitHub's six hour default. On #7645 thePR Build (Linux) / Spark 3.4, JDK 17, Scala 2.12 [shuffle]job hung inCometShuffleSuiteat 21:54 and was cancelled at 03:49. The same job takes 10 to 14 minutes on other pull requests. For those six hours it held a runner, and nobody saw a failure.What changes are included in this PR?
Every job that runs on a runner now sets
timeout-minutes. Each limit is about two to three times the slowest successful run of that job across recent merge queue, nightly and pull request runs, rounded up.A job that calls a reusable workflow cannot set
timeout-minutes, so the limits are on the jobs insidepr_build_linux.yml,spark_sql_test_reusable.ymland the other reusable workflows. Every limit is well below the merge queue'scheck_response_timeout_minutes: 300.A new "Job timeouts" section in
.github/workflows/README.mdexplains how the limits were chosen. It also says that a pull request that makes a job slower should raise that job's limit, not remove it.How are these changes tested?
Every workflow file still parses, and a script confirmed that every job with
runs-onnow hastimeout-minutes. The README passesprettier --check. This pull request's own CI runs under the new limits. Some limits are based on only two successful runs, mostly with a warm cache, so the build limits are set generously to allow for a cold cache.🤖 Generated with Claude Code