Repository navigation
ci: [branch-1.2] set timeout-minutes on every workflow job (backport #7679) - #7682
Merged
Merged
Conversation
Without timeout-minutes a job runs for GitHub's six hour default. A hung suite then holds a runner, and its pipeline, for six hours before it reports. Set a limit on every job that runs on a runner, at about two to three times its slowest recent successful run, and document how the limits were chosen in the workflows README. (cherry picked from commit 4b73842) Adapted for branch-1.2: ci_fork.yml and the linux-test-native-executors and deploy-docs jobs do not exist on this branch, so their limits are dropped. docs.yaml builds and publishes in one job, which gets the 60 minute build limit. label_prs.yml, which main no longer has in this form, gets a 10 minute limit.
andygrove
marked this pull request as draft
November 18, 2026 23:43
andygrove
marked this pull request as ready for review
November 19, 2026 14:08
comphead
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #7679 to
branch-1.2. #7679 is approved but not merged yet, so this should merge after it. There is no issue.Rationale for this change
No job in the workflows sets
timeout-minutes, so each one gets GitHub's six hour default. A hung suite holds a runner, and its pipeline, for six hours before it reports a failure. This came up while investigating CI failures on thebranch-1.2backports, and the branch has the same workflows, so it needs the same limits. CI changes for the branch's own build qualify for a backport (see the backporting guide).What changes are included in this PR?
The same limits as #7679, applied to the jobs this branch has. The cherry-pick conflicted because
branch-1.2is older thanmain:ci_fork.ymldoes not exist here, so its change is dropped.pr_build_linux.ymlhas nolinux-test-native-executorsjob, so that limit is dropped. The other limits are unchanged.docs.yamlbuilds and publishes in one job instead of separate build and deploy jobs. That job gets the 60 minute build limit.label_prs.ymlalso has a job that ci: set timeout-minutes on every workflow job #7679 does not touch, becausemainno longer has it in this form. It gets a 10 minute limit like the other labelling jobs.Every job with
runs-onnow hastimeout-minutes. The README section is unchanged from #7679 and its references (pr_build_linux.yml,spark_sql_test_reusable.yml, the merge queue'scheck_response_timeout_minutes: 300) all exist on this branch.How are these changes tested?
actionlint,dev/ci/check-ci-config.pyandprettier --checkon the README pass. A script confirmed that every job withruns-onhastimeout-minutes. This pull request's own CI runs under the new limits.