fix: simplify edge-to-edge preference logic in CordovaActivity and SystemBarPlugin#1902
Conversation
|
This appears to have introduce an issue on Android 7 where content is rendered behind the navigation bar, which should not happen, and results in parts of the page not being visible. While I understand the idea is to try and re-implement the behavior of Android’s edge-to-edge behavior on the other hand would applies to both the status bar and the navigation bar, while E2E was not the original behavior of the previous preference. |
If this only affects Android 7, maybe we can set the minimum Android to 8? |
I think you are right. It's confusing to enable AndroidEdgeToEdge for Android versions pre 15. It should have no effect on Android < 15. Would you make a PR for it? |
|
It would be also possible to hide the statusbar by the new Status Bar JS API |
|
I opened PR #1962, which will revert this PR. |
Simplify edge-to-edge preference logic
Platforms affected
Android
Motivation and Context
The motivation and context was described here: apache/cordova-discuss#114
When having cordova android in Edge To Edge the app does not extend to the full height of the device in version bellow Android 15. This change allows the app to behave the same way it was possible to do with the statusbar plugin preference
StatusBarOverlaysWebViewgiven that this stopped having any effect in cordova-android 15.Description
This PR removes the limitation for Android version <15 when preference
AndroidEdgeToEdgeis true.Testing
Tested in Android 12, 13 and 16
Checklist
(platform)if this change only applies to one platform (e.g.(android))