Skip to content

chore: Update vendored flatcc and regenerate flatcc headers - #854

Merged
paleolimbot merged 6 commits into
apache:mainfrom
paleolimbot:update-ipc-headers
Mar 6, 2026
Merged

paleolimbot merged 6 commits into
apache:mainfrom
paleolimbot:update-ipc-headers

Conversation

@paleolimbot

@paleolimbot paleolimbot commented Mar 5, 2026 •

Copy link
Copy Markdown
Member

The updates to flatcc since the last time we did this are minimal. I kept two modifications (ignoring a dead store for clang-analyzer and ensuring that the align macro continues to be suppressed for clang that already has it built in). I added one more for #850 (commenting out flatbuffers_true and flatbuffers_false, which are never used).

The arrow format spec has been updated slightly but I think these are just comments (we already support decimal32/64).

Closes #850.

root@60c644e4d256:/arrow-nanoarrow/r# R CMD INSTALL .
* installing to library '/usr/local/lib/R/site-library'
* installing *source* package 'nanoarrow' ...
** using staged installation
Vendoring files from arrow-nanoarrow to src/:
[0] python3 ../ci/scripts/bundle.py  --symbol-namespace=RPkg --header-namespace= --include-output-dir=src --source-output-dir=src --with-ipc --with-flatcc
Found vendored nanoarrow
Using PKG_CPPFLAGS=
Using PKG_LIBS=
** libs
using C compiler: 'gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0'
using C++ compiler: 'g++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0'
gcc -I"/usr/share/R/include" -DNDEBUG -I../inst/include -I../src -DFLATCC_USE_GENERIC_ALIGNED_ALLOC       -fPIC  -Wunused-const-variable -Wmisleading-indentation -c flatcc.c -o flatcc.o
gcc -I"/usr/share/R/include" -DNDEBUG -I../inst/include -I../src -DFLATCC_USE_GENERIC_ALIGNED_ALLOC       -fPIC  -Wunused-const-variable -Wmisleading-indentation -c nanoarrow.c -o nanoarrow.o
gcc -I"/usr/share/R/include" -DNDEBUG -I../inst/include -I../src -DFLATCC_USE_GENERIC_ALIGNED_ALLOC       -fPIC  -Wunused-const-variable -Wmisleading-indentation -c nanoarrow_ipc.c -o nanoarrow_ipc.o
g++ -std=gnu++17 -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -Wl,-z,relro -o nanoarrow.so altrep.o array.o array_stream.o array_view.o as_array.o buffer.o convert.o convert_array.o convert_array_stream.o flatcc.o infer_ptype.o init.o ipc.o materialize.o nanoarrow.o nanoarrow_cpp.o nanoarrow_ipc.o pointers.o schema.o util.o vctr.o version.o -L/usr/lib/R/lib -lR
installing to /usr/local/lib/R/site-library/00LOCK-r/00new/nanoarrow/libs
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** checking absolute paths in shared objects and dynamic libraries
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (nanoarrow)

@paleolimbot
paleolimbot marked this pull request as ready for review March 5, 2026 20:56
@paleolimbot
paleolimbot merged commit e7498af into apache:main Mar 6, 2026
42 checks passed
@paleolimbot
paleolimbot deleted the update-ipc-headers branch March 6, 2026 14:41
rustyconover pushed a commit to rustyconover/arrow-nanoarrow that referenced this pull request Oct 26, 2026
Regenerated with dev/update_fbs.sh (flatcc e3e44836) from apache/arrow
main, with whitespace cleaned by the pre-commit hooks. This picks up the
upstream .fbs changes since apache#854, which only change comments (e.g. the
docstring fixes from apache/arrow#50826 and the Tensor/SparseTensor
deprecation notes from apache/arrow#51102).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Feature request: More silent build

1 participant