Skip to content

Vendored flatcc: update for CVE-2026-116734 (verifier overflow guard) #1024

Open

Description

@jacob-ablowitz

The vendored flatcc in thirdparty/flatcc still has the overflow guard that flatcc fixed for CVE-2026-116734 (GHSA-ch33-r734-vw2g).

thirdparty/flatcc/src/runtime/verifier.c, check_header() (line 130 on main at b7a56da):

if (uoffset_size <= voffset_size && k + offset_size < k) {

Upstream fix, dvidelabs/flatcc@0df9c097 ("Fix incorrect overflow guard in verifier"), drops the first condition:

if (k + offset_size < k) {

With the default uoffset_t/voffset_t sizes the first condition is false, so the wrap check never runs. The advisory names 32-bit builds. nanoarrow's IPC decoder runs this verifier on every message (Message_verify_as_root in src/nanoarrow/ipc/decoder.c), so a crafted Arrow IPC stream can pass verification with a wrapped offset and read out of bounds. That matters most for wasm32 builds that decode streams in the browser, e.g. DuckDB-Wasm via duckdb-nanoarrow.

Could the vendored flatcc be updated to include 0df9c097 (or a release that contains it)? The last revendor was #854. Happy to open a PR with the one-line change if that's preferred over a full revendor.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions