Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/nanoarrow/ipc/decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -1977,6 +1977,10 @@ ArrowErrorCode ArrowIpcDecoderDecodeFooter(struct ArrowIpcDecoder* decoder,
const uint8_t* footer_data =
data.data.as_uint8 + data.size_bytes - footer_and_size_and_magic_size;
ns(Footer_table_t) footer = ns(Footer_as_root(footer_data));
if (ns(Footer_schema(footer)) == NULL) {
ArrowErrorSet(error, "Footer has no schema");
return EINVAL;
}

NANOARROW_RETURN_NOT_OK(
ArrowIpcDecoderDecodeSchemaHeader(decoder, ns(Footer_schema(footer)), error));
Expand Down
22 changes: 22 additions & 0 deletions src/nanoarrow/ipc/decoder_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,28 @@ TEST(NanoarrowIpcTest, NanoarrowIpcFooterSizeOverflow) {
EXPECT_EQ(ArrowIpcDecoderDecodeFooter(decoder.get(), data, &error), ESPIPE);
}

TEST(NanoarrowIpcTest, NanoarrowIpcFooterMissingSchema) {
struct ArrowError error;

nanoarrow::ipc::UniqueDecoder decoder;
ArrowIpcDecoderInit(decoder.get());

// A Footer flatbuffer with an empty table (no schema, no blocks), followed by
// the footer size (12) and the magic bytes
alignas(8) const uint8_t footer_bytes[] = {
8, 0, 0, 0, 4, 0, 4, 0, 4, 0, 0, 0, 12, 0, 0, 0, 'A', 'R', 'R', 'O', 'W', '1'};
struct ArrowBufferView data = {{footer_bytes}, sizeof(footer_bytes)};

EXPECT_EQ(ArrowIpcDecoderVerifyFooter(decoder.get(), data, &error), EINVAL);
EXPECT_STREQ(error.message, "Footer has no schema");

EXPECT_EQ(ArrowIpcDecoderPeekFooter(decoder.get(), data, &error), NANOARROW_OK)
<< error.message;
error.message[0] = '\0';
EXPECT_EQ(ArrowIpcDecoderDecodeFooter(decoder.get(), data, &error), EINVAL);
EXPECT_STREQ(error.message, "Footer has no schema");
}

#if defined(NANOARROW_BUILD_TESTS_WITH_ARROW)
class ArrowTypeParameterizedTestFixture
: public ::testing::TestWithParam<std::shared_ptr<arrow::DataType>> {
Expand Down
Loading