Repository navigation
fix(ipc): Return EINVAL from ArrowIpcDecoderDecodeFooter when the footer has no schema - #1023
Merged
paleolimbot merged 1 commit intoNov 17, 2026
Conversation
…ter has no schema DecodeFooter now checks for a missing schema the same way VerifyFooter does, instead of reading fields from a NULL schema table.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 78.59% 78.61% +0.02%
==========================================
Files 106 106
Lines 17328 17331 +3
Branches 2067 2068 +1
==========================================
+ Hits 13619 13625 +6
+ Misses 2446 2444 -2
+ Partials 1263 1262 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1022
ArrowIpcDecoderDecodeFooter()reads fields from the footer's schema table without checking that the footer has one. A footer without the optionalschemafield aborts in a Debug build.This adds the same check that
ArrowIpcDecoderVerifyFooter()already has: when the footer has no schema, it sets the error message "Footer has no schema" and returnsEINVAL. The public header says DecodeFooter returnsEINVALwhen the footer cannot be decoded.Test: adds
NanoarrowIpcTest.NanoarrowIpcFooterMissingSchemainsrc/nanoarrow/ipc/decoder_test.cc. It uses a 22-byte footer with no schema and checks that both VerifyFooter and DecodeFooter returnEINVALwith that message.How it was tested:
Checklist: