Skip to content

Regenerate DTO types and fix e2e smoke tests #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antosubash merged 2 commits into from
Mar 30, 2026
Merged

Regenerate DTO types and fix e2e smoke tests #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babe059
fix: Resolve 3 failing e2e smoke tests
antosubash Mar 30, 2026
7202fb9
chore: Regenerate TypeScript DTO types from source generator
antosubash Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/Admin/src/SimpleModule.Admin/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
// Auto-generated from [Dto] types — do not edit
export type AdminPermissions = {};
export interface AdminPermissions {
}

8 changes: 8 additions & 0 deletions modules/OpenIddict/src/SimpleModule.OpenIddict/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
// Auto-generated from [Dto] types — do not edit
export interface UserSessionDto {
tokenId: string;
type: string;
applicationName: string;
creationDate: string | null;
expirationDate: string | null;
}

export interface OpenIddictPermissions {
}

3 changes: 3 additions & 0 deletions modules/Users/src/SimpleModule.Users/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ export interface AdminUserDto {
displayName: string;
email: string;
emailConfirmed: boolean;
twoFactorEnabled: boolean;
roles: string[];
isLockedOut: boolean;
isDeactivated: boolean;
accessFailedCount: number;
createdAt: string;
lastLoginAt: string;
}

export interface RoleDto {
Expand Down
28 changes: 27 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/e2e/pages/pagebuilder/manage.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class PageBuilderManagePage {
}

get heading() {
return this.page.getByRole('heading', { name: /pages/i });
return this.page.getByRole('heading', { name: 'Pages', exact: true });
}

get newPageButton() {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/pages/pagebuilder/pages-list.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export class PageBuilderPagesListPage {
}

get heading() {
return this.page.getByRole('heading', { name: /pages/i });
return this.page.getByRole('heading', { name: 'Pages', exact: true });
}

get emptyMessage() {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/smoke/filestorage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test.describe('FileStorage smoke', () => {

test('browse page redirects to login', async ({ page }) => {
const response = await page.goto('/files/browse');
expect(response?.url()).toContain('/Identity/Account/Login');
expect(response?.url()).toContain('/Account/Login');
});

test('API endpoint returns 302', async ({ request }) => {
Expand Down