Skip to content

Regenerate DTO types and fix e2e smoke tests - #34

Merged
antosubash merged 2 commits into
mainfrom
feature/practical-diffie
Mar 30, 2026
Merged

antosubash merged 2 commits into
mainfrom
feature/practical-diffie

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Changes

TypeScript DTO Types

  • Admin module: Convert AdminPermissions type to interface format
  • OpenIddict module: Add new UserSessionDto interface with token and session properties
  • Users module: Add missing fields to AdminUserDto:
    • twoFactorEnabled
    • accessFailedCount
    • lastLoginAt

E2E Test Fixes

  • Fix page heading selectors in PageBuilder tests to use exact matching instead of regex patterns
  • Update FileStorage redirect test to match new login URL path (/Account/Login instead of /Identity/Account/Login)

Dependencies

  • Update package-lock.json to mark peer dependencies correctly

- PageBuilder heading selectors used /pages/i regex which matched both
  the page title and empty-state headings, violating Playwright strict
  mode. Switched to exact match.
- FileStorage unauthenticated redirect test expected /Identity/Account/Login
  but the app now redirects to /Account/Login.
Updated auto-generated types.ts files to reflect recent C# [Dto] changes:
- OpenIddict: added UserSessionDto
- Users: added twoFactorEnabled, accessFailedCount, lastLoginAt fields
- Admin: type alias → interface (codegen format change)
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simplemodule-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7202fb9
Status: ✅  Deploy successful!
Preview URL: https://8d97bb25.simplemodule-website.pages.dev
Branch Preview URL: https://feature-practical-diffie.simplemodule-website.pages.dev

View logs

@antosubash
antosubash merged commit d4f44e2 into main Mar 30, 2026
3 checks passed
@antosubash
antosubash deleted the feature/practical-diffie branch April 1, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant