Skip to content

fix(tests): read changelog as UTF-8 #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rioyu123 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): read changelog as UTF-8 #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ def test_changelog_exists(self):
assert self.changelog_path.exists(), "CHANGELOG.md file should exist"

def test_changelog_starts_with_header(self):
content = self.changelog_path.read_text()
content = self.changelog_path.read_text(encoding="utf-8")
assert content.startswith("# Changelog"), (
"Changelog should start with '# Changelog'"
)

def test_changelog_has_valid_version_format(self):
content = self.changelog_path.read_text()
content = self.changelog_path.read_text(encoding="utf-8")
lines = content.split("\n")

version_pattern = re.compile(r"^## \d+\.\d+\.\d+(?:\s+\(\d{4}-\d{2}-\d{2}\))?$")
Expand All @@ -32,7 +32,7 @@ def test_changelog_has_valid_version_format(self):
assert len(versions) > 0, "Changelog should contain at least one version"

def test_changelog_has_bullet_points(self):
content = self.changelog_path.read_text()
content = self.changelog_path.read_text(encoding="utf-8")
lines = content.split("\n")

in_version_section = False
Expand Down Expand Up @@ -61,7 +61,7 @@ def test_changelog_has_bullet_points(self):
)

def test_changelog_versions_in_descending_order(self):
content = self.changelog_path.read_text()
content = self.changelog_path.read_text(encoding="utf-8")
lines = content.split("\n")

versions = []
Expand All @@ -77,7 +77,7 @@ def test_changelog_versions_in_descending_order(self):
)

def test_changelog_no_empty_bullet_points(self):
content = self.changelog_path.read_text()
content = self.changelog_path.read_text(encoding="utf-8")
lines = content.split("\n")

for line in lines:
Expand Down