fix(tests): read changelog as UTF-8 - #1236
Open
rioyu123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read
CHANGELOG.mdexplicitly as UTF-8 in its test module.The changelog now contains Unicode punctuation, but the tests used
Path.read_text()without an encoding. On Windows hosts whose locale encodingis CP936/GBK, all five content-based changelog tests fail with
UnicodeDecodeErrorbefore reaching their assertions. UTF-8 is the repositoryfile encoding and is already used explicitly by other readers in the SDK.
This keeps the change limited to the five affected reads; test behavior is
otherwise unchanged.
Testing
5 failed, 1542 passed, 12 skippedon Windows CP9361547 passed, 12 skippeduv run ruff check tests/test_changelog.pyuv run ruff format --check tests/test_changelog.pyPrepared with AI assistance and reviewed against the reported Windows failure;
the full test suite and focused lint/format checks were run locally.